This repository has been archived by the owner on Jul 15, 2023. It is now read-only.
Cache results of 'go list' when fetching package info to get package variables #2289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'go list' command is expensive so the result should be cached. There was a cache in place but it wasn't being populated.
|
Related to #1854 |
ramya-rao-a
reviewed
Jan 29, 2019
There was a problem hiding this comment.
I am feeling very stupid right now :(
This definitely should solve a major part of the perf problem.
Lets change the default value of showGlobalVariables to true.
I'll reach out to folks whose perf issues got solved by this setting and ask them to give the new beta a try.
ramya-rao-a
changed the title
ramya-rao-a
approved these changes
Jan 29, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'go list' command is expensive so the result should be cached.
There was a cache in place but it wasn't being populated.