Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pressing enter in both *Select Interpreter to start Jupyter server* and *Specify local or remote Jupyter server for connections* is being ignored #4037

Closed
205g0 opened this issue Nov 27, 2020 · 10 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug

Comments

@205g0
Copy link

205g0 commented Nov 27, 2020

Environment data

  • VS Code version: 1.5.1.1

  • Jupyter Extension version (available under the Extensions sidebar): v2020.11.372831992

  • Python Extension version (available under the Extensions sidebar): v2020.11.371526539

  • OS (Windows | Mac | Linux distro) and version: Windows 2004

  • Python and/or Anaconda version: 3.8.3

  • Type of virtual environment used (N/A | venv | virtualenv | conda | ...): XXX

  • Jupyter server running: N/A

Expected behaviour

Pressing enter in both Select Interpreter to start Jupyter server and Specify local or remote Jupyter server for connections takes my remote URI.

Actual behaviour

Pressing enter in both Select Interpreter to start Jupyter server and Specify local or remote Jupyter server for connections is being ignored and the input box stays open.

Steps to reproduce:

Open Command Palette search for commands above, enter some URI and try to press enter.

Logs

No output in output panel.

@205g0 205g0 added the bug Issue identified by VS Code Team member as probable bug label Nov 27, 2020
@205g0
Copy link
Author

205g0 commented Nov 28, 2020

Ok, this seems to be broken to the ground hurting the overall UX.

I found following workaround for others driving by and as a note for myself since getting it up and running is complicated:

  1. Start your local Jupyter, even if you don't need it, you need it to be there just to get started
  2. Look that default interpreter and server are set to local ones using the command palette menu
  3. Run a random code piece, so that the interactive tab opens and runs the code locally, doesn't matter if the code works, in my case usually some libs are missing I have on my server
  4. In the interactive tab click on the Jupyter server info top right and only there and NOT in the command palette
  5. Set the remote server and enter should hopefully work this time

After that you can close your local Jupyter instance.

@claudiaregio
Copy link
Contributor

Hi @205g0, I am not able to reproduce this issue at this time. Could you please provide a gif showing us what is happening?
If you need a tool, ScreenToGif works pretty well. https://www.screentogif.com/

@claudiaregio claudiaregio added the info-needed Issue requires more information from poster label Nov 30, 2020
@greazer
Copy link
Member

greazer commented Dec 1, 2020

We think this is probably a VS Code issue.

@rebornix
Copy link
Member

rebornix commented Dec 1, 2020

@205g0 when you run into this issue next time, could you please run a troubleshooting command "Developer: Toggle Keyboard Shortcuts Troubleshooting" and then repeat the * Select Interpreter* steps again, and lastly share the log from the outputs panel? This can help us understand which component is hijacking the enter key.

@markushi
Copy link

markushi commented Dec 4, 2020

The same issue is happening to me as well. After some trial and error I found out that the extension tries to write "jupyter.jupyterServerType": "remote" to .vscode/settings.json but fails when no workspace is open.

Workaround: Open a workspace/folder first

If you need any more details, just let me know.

@edofullin
Copy link

I had the same issue as well, the problem turned out to be that the OS I was using (Linux Manjaro KDE) did not have Gnome Keyring installed (ofc it doesn't, it's KDE) and that seems to be a required package.

@205g0
Copy link
Author

205g0 commented Dec 5, 2020

Thanks for looking into this and apologies for my late reply. I couldn't reproduce my issue anymore. Now, I can directly open the select remote server dialogue, click existing, add my server URI and press enter. Feel free to close this issue, I will observe this and come back with more info if I encounter this problem again.

Edit: Just saw @markushi 's post and checked it myself and yes, that was the reason. Now I am using it in a proper workspace and hence it works. When trying to do this with a plain file I get an error which is not clear. So, either this error is fixed or at least the error messege should be clear, something like "workspace needed to setup remote Jupyter" or something. Otherwise people might waste quite some time like I did, get grumpy and miss an awesome feature.

Since VS Code's overall Python Interactive UI/workflow is currently one of the best (if not the best), it would be great to iron out this issue because nobody has beefy TPUs on their local machine and setting up a remote machine for the use case DL/ML is the norm I assume.

@IanMatthewHuff
Copy link
Member

IanMatthewHuff commented Dec 17, 2020

Moving this back to new triage category as info has been provided. We missed the new comments here as it was mistakenly assumed to be a general VS Code input issue on our side. Sorry about the issue here, but a fix might be a bit slow coming as most of the team is out over the holidays.

@rchiodo rchiodo self-assigned this Jan 4, 2021
@rchiodo rchiodo removed the info-needed Issue requires more information from poster label Jan 4, 2021
@joyceerhl
Copy link
Contributor

Validated. For 'Select Interpreter to start Jupyter server' and 'Specify local or remote server for connections', hitting enter with a quickpick item selected results in that selection being taken and advancing to the next step in the multistep quickpick.

@gitony0101
Copy link

The same issue is happening to me as well. After some trial and error I found out that the extension tries to write "jupyter.jupyterServerType": "remote" to .vscode/settings.json but fails when no workspace is open.

Workaround: Open a workspace/folder first

If you need any more details, just let me know.

yep I made it by changing but idw how it works

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

No branches or pull requests

10 participants