Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installing the python extension should use the 'extension.open' command instead of opening the URL #4664

Closed
rchiodo opened this issue Feb 5, 2021 · 4 comments
Labels
bug Issue identified by VS Code Team member as probable bug

Comments

@rchiodo
Copy link
Contributor

rchiodo commented Feb 5, 2021

See @jakebailey 's PR here:
microsoft/vscode-python#15321

@rchiodo rchiodo added the bug Issue identified by VS Code Team member as probable bug label Feb 5, 2021
@rchiodo rchiodo closed this as completed Feb 5, 2021
@rchiodo rchiodo reopened this Feb 5, 2021
@IanMatthewHuff
Copy link
Member

IanMatthewHuff commented Feb 9, 2021

Does this need to be tested on codespaces? I gave it a try locally and it worked popping up the same page as before. Did find one new issue that I filed separate: #4724. @rchiodo

@rchiodo
Copy link
Contributor Author

rchiodo commented Feb 9, 2021

Yeah it would be nice to test on codespaces. @joyceerhl can you try it out?

@rchiodo
Copy link
Contributor Author

rchiodo commented Feb 9, 2021

To validate:

  1. Install just jupyter extension
  2. Export from the interactive window.

@joyceerhl
Copy link
Contributor

Webviews seem to all be busted in Codespaces right now, but if I install the Jupyter extension, create a blank native notebook and hit 'yes' on the prompt which recommends installing the Python extension, the install page correctly shows up in my Codespace.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

No branches or pull requests

3 participants