Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide all but 3 of our icons in the native notebook #4730

Closed
rchiodo opened this issue Feb 10, 2021 · 3 comments
Closed

Hide all but 3 of our icons in the native notebook #4730

rchiodo opened this issue Feb 10, 2021 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug

Comments

@rchiodo
Copy link
Contributor

rchiodo commented Feb 10, 2021

For both stable and insiders hide all but 3.

The 3 are to be determined.

Others can be forced into the overflow menu.

@rchiodo rchiodo added the bug Issue identified by VS Code Team member as probable bug label Feb 10, 2021
@claudiaregio
Copy link
Contributor

claudiaregio commented Feb 10, 2021

Top 3 to be used:

  1. Restart kernel
  2. Variable Explorer
  3. Export As
    When kernel is in busy state, turn the restart kernel notebook toolbar icon into the STOP EXECUTION RED SQUARE ICON. When kernel is in idle state, turn back into the kernel restart icon.

Untrusted icon to be the only icon displayed in the toolbar until notebook is trusted.

*Change for both stable and insiders so experience is consistent for both

@rchiodo
Copy link
Contributor Author

rchiodo commented Feb 10, 2021

Not sure yet about the the icon/command changing.

This might work:

                {
                    "command": "jupyter.notebookeditor.restartkernel",
                    "title": "%jupyter.command.jupyter.restartkernel.title%",
                    "group": "navigation@3",
                    "when": "notebookViewType == 'jupyter-notebook' && !jupyter.isbusy"
                },
                {
                    "command": "jupyter.notebookeditor.interruptkernel",
                    "title": "%jupyter.command.jupyter.interruptkernel.title%",
                    "group": "navigation@3",
                    "when": "notebookViewType == 'jupyter-notebook' && jupyter.isbusy"
                },

I'd have to code it up to find out.

@IanMatthewHuff
Copy link
Member

Validated.
image.png
Restart, Variable, Export As

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

No branches or pull requests

3 participants