Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt notebook/toolbar contribution point for native notebooks #5954

Closed
joyceerhl opened this issue May 21, 2021 · 3 comments
Closed

Adopt notebook/toolbar contribution point for native notebooks #5954

joyceerhl opened this issue May 21, 2021 · 3 comments
Assignees

Comments

@joyceerhl
Copy link
Contributor

Just had a chat with @rebornix about this. With Sunday night's Insiders build, extensions will be able to contribute items to notebook/toolbar, with the following groups:

  • navigation/edit
  • navigation/execute <-- This will house restart kernel and interrupt kernel
  • navigation <-- This will house other actions like open variable view and export
  • status <-- This appears on the right of the notebook toolbar and currently houses only the kernel picker. In future we can consider moving the local/remote status item up here, but for now we should not contribute to this group

We will be able to specify a shortTitle for each command that appears in the notebook toolbar. When present, this shortTitle attribute will be displayed next to the command's associated codicon in the toolbar, so as not to take up too much horizontal space with a lengthier title. VS Code will then pick either shortTitle or the existing title to display depending on context.

@joyceerhl joyceerhl self-assigned this May 21, 2021
@claudiaregio
Copy link
Contributor

Wahoooo ok entry points to move into the notebook toolbar:

  1. Short Title: Restart , Title: Restart Kernel - Navigation/Execute
  2. Short Title: Interrupt, Title: Interrupt Kernel - Navigation/Execute
  3. Short Title: Variables, Title: Open Variable View - Navigation
  4. Short Title: Export, Title: Export As - Navigation

@joyceerhl
Copy link
Contributor Author

PR has been merged, should go out in tonight's Jupyter extension insiders build.

@joyceerhl joyceerhl added this to the June 2021 Release milestone Jun 4, 2021
@IanMatthewHuff
Copy link
Member

Validated.
image.png

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants