Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new code lens codeWatcher is created for every edit without disposing the previous one #8919

Closed
amunger opened this issue Feb 3, 2022 · 0 comments · Fixed by #9221
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug debt Code quality issues interactive-window Impacts interactive window perf Performance issues

Comments

@amunger
Copy link
Contributor

amunger commented Feb 3, 2022

Found while adding some logging to troubleshoot a test, but this could potentially be leaking memory:

Info 13:04:13: Adding hash for 5 = 530ca6997d93 with 2 lines
Info 13:04:13: Cell 8 executed with state Success
Info 13:04:13: updating code lenses for version 2 of document file:///c%3A/src/test/2/script2.py

edit performed
Info 13:04:23: creating new code watcher with matching document file:///c%3A/src/test/2/script2.py
Info 13:04:23: Generating new code lenses for version 3 of document file:///c%3A/src/test/2/script2.py

Info 13:04:26: Adding hash for 6 = 6794747d16e6 with 3 lines
Info 13:04:26: Cell 9 executed with state Success
Info 13:04:26: updating code lenses for version 3 of document file:///c%3A/src/test/2/script2.py
Info 13:04:26: updating code lenses for version 3 of document file:///c%3A/src/test/2/script2.py

edit performed
Info 13:04:31: creating new code watcher with matching document file:///c%3A/src/test/2/script2.py
Info 13:04:31: Generating new code lenses for version 4 of document file:///c%3A/src/test/2/script2.py
edit performed
Info 13:04:33: creating new code watcher with matching document file:///c%3A/src/test/2/script2.py
Info 13:04:33: Generating new code lenses for version 5 of document file:///c%3A/src/test/2/script2.py

Info 13:04:35: Adding hash for 7 = 5da380be1d28 with 5 lines
Info 13:04:35: Cell 10 executed with state Success
Info 13:04:35: updating code lenses for version 5 of document file:///c%3A/src/test/2/script2.py
Info 13:04:35: updating code lenses for version 5 of document file:///c%3A/src/test/2/script2.py
Info 13:04:35: updating code lenses for version 5 of document file:///c%3A/src/test/2/script2.py
Info 13:04:35: updating code lenses for version 5 of document file:///c%3A/src/test/2/script2.py

@amunger amunger added the bug Issue identified by VS Code Team member as probable bug label Feb 3, 2022
@amunger amunger added debt Code quality issues needs-triage and removed needs-triage labels Feb 3, 2022
@greazer greazer added perf Performance issues interactive-window Impacts interactive window and removed needs-triage labels Feb 7, 2022
@amunger amunger self-assigned this Mar 2, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug debt Code quality issues interactive-window Impacts interactive window perf Performance issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants