Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialisation exceptions swallowed #330

Closed
nwolverson opened this issue Mar 29, 2018 · 1 comment
Closed

Initialisation exceptions swallowed #330

nwolverson opened this issue Mar 29, 2018 · 1 comment

Comments

@nwolverson
Copy link

I just had trouble diagnosing a LanguageClient which did not resolve or reject the onReady promise, and I could not find an exception noted anywhere.

Similar to this issue - there was an exception in initializeFeatures https://github.com/Microsoft/vscode-languageserver-node/blob/020764e3eacc76138ffbf63f09489adbfb9e1be8/client/src/client.ts#L2614

Is this as simple as moving then(..., ...) to then(...).catch(...) ?

@dbaeumer
Copy link
Member

dbaeumer commented Apr 3, 2018

@nwolverson thanks. Since VS Code's Thenable interface doesn't offer a catch I changed it to then(...).then(undefined, ....).

@vscodebot vscodebot bot locked and limited conversation to collaborators May 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants