Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run unit tests as a githook #1703

Closed
DonJayamanne opened this issue May 16, 2018 · 0 comments · Fixed by #1697
Closed

Run unit tests as a githook #1703

DonJayamanne opened this issue May 16, 2018 · 0 comments · Fixed by #1697
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Milestone
May 2018

Comments

@DonJayamanne
Copy link

No description provided.

@DonJayamanne DonJayamanne added needs PR debt Covers everything internal: CI, testing, refactoring of the codebase, etc. labels May 16, 2018
@DonJayamanne DonJayamanne added this to the May 2018 milestone May 16, 2018
@DonJayamanne DonJayamanne mentioned this issue May 16, 2018
Merged
2 tasks
DonJayamanne added a commit that referenced this issue May 21, 2018
@DonJayamanne
Fix getting display name and version when using windows registry (#1697)
35fe3c0 
* Fixes #1660
* Fixes #1703
* 🐛 fix getting display name and version when using windows registry
* Git hook for tests
* 📝 add news entry
* Some more unit tests\
* Mock VS Code only inside the test runner
* Singleton mocks for vscode namespcaes
* Fix test
@lock lock bot locked as resolved and limited conversation to collaborators Jul 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Projects
None yet
Milestone
May 2018
Development

Successfully merging a pull request may close this issue.

Fix getting display name and version when using windows registry DonJayamanne/pythonVSCode
2 participants
@brettcannon @DonJayamanne