Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Lenses not appearing in Unit Tests when using the new language server #1948

Closed
DonJayamanne opened this issue Jun 13, 2018 · 2 comments · Fixed by #2456
Closed

Code Lenses not appearing in Unit Tests when using the new language server #1948

DonJayamanne opened this issue Jun 13, 2018 · 2 comments · Fixed by #2456
Assignees
Labels
area-testing bug Issue identified by VS Code Team member as probable bug
Milestone

Comments

@DonJayamanne
Copy link

The functionality is disabled as symbol definitions wasn't available until #1934

@DonJayamanne DonJayamanne added bug Issue identified by VS Code Team member as probable bug needs PR area-testing labels Jun 13, 2018
@DonJayamanne DonJayamanne added this to the July 2018 milestone Jun 13, 2018
@DonJayamanne DonJayamanne self-assigned this Jun 13, 2018
@brettcannon brettcannon removed this from the Jul 2018 milestone Jul 19, 2018
@DonJayamanne DonJayamanne added the important Issue identified as high-priority label Jul 27, 2018
@DonJayamanne
Copy link
Author

DonJayamanne commented Jul 27, 2018

Users @ EuroPython (Intellicode + New language server) have already come across this issue.

Depends on #2050 and #2197

@DonJayamanne DonJayamanne modified the milestones: Sep 2018, Aug 2018 Jul 27, 2018
@brettcannon brettcannon added P0 and removed important Issue identified as high-priority labels Jul 27, 2018
@brettcannon brettcannon modified the milestone: Aug 2018 Aug 2, 2018
@DonJayamanne DonJayamanne changed the title Code Lenses not appearing in Unit Tests when using analysis engine Code Lenses not appearing in Unit Tests when using the new language server Aug 10, 2018
@brettcannon brettcannon modified the milestone: Aug 2018 Aug 13, 2018
@ericsnowcurrently
Copy link
Member

ericsnowcurrently commented Aug 29, 2018

Repro:

With the following, code lenses show up with Jedi but do not when using the language server.

# files:
tests/
   __init__.py
   spam.py
# tests/test_spam.py
import unittest

class SpamTests(unittest.TestCase):
    def test_all(self):
        self.assertTrue(False)

@lock lock bot locked as resolved and limited conversation to collaborators Oct 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.