Detect when language server will not run on a platform (e.g. macOS El Capitan)

[Nozdi]

Environment data

• VS Code version: 1.25.1
• Extension version (available under the Extensions sidebar): 2018.7.1
• OS and version: MacOS El Capitan (10.11.6)
• Python version (& distribution if applicable, e.g. Anaconda): Python 2.7.15
• Type of virtual environment used (N/A | venv | virtualenv | conda | ...): venv
• Relevant/affected Python packages and their versions:

Actual behavior

Extension is crashing:

dyld: Symbol not found: _clock_gettime
  Referenced from: /Users/nozdi/.vscode/extensions/ms-python.python-2018.7.1/languageServer/libcoreclr.dylib (which was built for Mac OS X 10.12)
  Expected in: /usr/lib/libSystem.B.dylib

[Error - 3:50:50 PM] Connection to server got closed. Server will not be restarted.

Expected behavior

Support for OS X < 10.12

Steps to reproduce:

Start vscode using LanguageServer on El Capitan (10.11.X)

[DonJayamanne]

@Nozdi
Unfortunately only 10.12 and later of OSX is supported.
https://docs.microsoft.com/en-us/dotnet/core/macos-prerequisites?tabs=netcore2x#supported-macos-versions

[DonJayamanne]

@brettcannon We should document the minimum requirements. Should this be done now or later. Either way it should be documented.

[karthiks3000]

Where do I find an older version that supports El Capitan?

[brettcannon]

[I edited your ✉️ ⬆️ to come off as more 😃 and less 😠 ]

@karthiks3000 you can still use Jedi to get IntelliSense on El Capitan: "python.jediEnabled": true. There's no need to downgrade the extension itself.

[brettcannon]

@DonJayamanne we probably need to detect the platforms where the new language server isn't supported and then not attempt a download and pop up a notification that the user will need to stick with Jedi.

[karthiks3000]

@brettcannon Apologies for the way the last message came off, I was under a tight deadline and had the autoUpdate enabled on my vscode. It wasn't the intellisense that bothered me but the fact that debugging on my Django project broke after the update. The project still builds fine, but debugging doesn't work anymore (someone already created a bug for the error I got when I tried to build in debug mode - #2247)

The only way I was able to move past this was to upgrade my OS to HighSierra.

[brettcannon]

@karthiks3000 no problem and thanks for the apology! We've all been there when your tooling breaks at the worst time. And sorry that we failed you at a critical moment!

[MikhailArkhipov]

Not LS issue. Need to add stricter OS detection to the extension code so it does not attempt to download and run the LS.

[ericsnowcurrently]

@MikhailArkhipov, FYI I've been working on this today (as I mentioned during standup). In the future please get in touch with me before unassigning me like that, so I don't waste time.

[DonJayamanne]

@ericsnowcurrently @MikhailArkhipov
We need to check the minimum requirements on all three platforms. Currently @MikhailArkhipov PR only checks for Mac

I think Eric's PR is better as it supports multiple OS.

[MikhailArkhipov]

There is In Progress state with ZenHub

[DonJayamanne]

There is In Progress state with ZenHub

To my knowledge no one (in our team and perhaps others too) uses that. We all (almost everyone) look at the Assignees section on the top right of the GitHub issue.

Please ensure you assign issues to your self if you are working on such issues. Helps others on the team.