Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for multi root workspaces with the new language server server #3008

Closed
DonJayamanne opened this issue Oct 24, 2018 · 1 comment
Closed

Add support for multi root workspaces with the new language server server #3008

DonJayamanne opened this issue Oct 24, 2018 · 1 comment
Assignees
@karrtikr
Labels
area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority
Milestone
2019, week 5 - Ja...

Comments

@DonJayamanne
Copy link

Based on #1149

Solution - Start multiple language clients one for each work space

Requirements:

  • Lazy load language clients (based on active workspace folder), i.e. don't open for each folder unnecessarily
  • Shutdown language client when a workspace folder is removed
@DonJayamanne DonJayamanne added bug Issue identified by VS Code Team member as probable bug area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. needs PR labels Oct 24, 2018
This was referenced Jan 25, 2019
Closed
Closed
Closed
Closed
@DonJayamanne DonJayamanne added the important Issue identified as high-priority label Jan 30, 2019
@DonJayamanne
Copy link
Author

activateWorkspace of src/client/activation/activationManager.ts

@karrtikr karrtikr mentioned this issue Jan 31, 2019
Merged
8 tasks
@ghost ghost removed the needs PR label Feb 13, 2019
@ericsnowcurrently ericsnowcurrently mentioned this issue Mar 13, 2019
Closed
@lock lock bot locked as resolved and limited conversation to collaborators Mar 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@karrtikr karrtikr

Labels
area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority
Projects
None yet
Milestone
2019, week 5 - Jan Sprint 3
Development

No branches or pull requests
2 participants
@DonJayamanne @karrtikr