Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle failure to activate extension and notify user #3740

Closed
DonJayamanne opened this issue Dec 18, 2018 · 3 comments
Closed

Handle failure to activate extension and notify user #3740

DonJayamanne opened this issue Dec 18, 2018 · 3 comments
Assignees
@ericsnowcurrently
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc. important Issue identified as high-priority
Milestone
2019, week 1 - Ja...

Comments

@DonJayamanne
Copy link

Handle errors in extension activation
Notify user with error message and information to diagnose this.
@DonJayamanne DonJayamanne added needs PR important Issue identified as high-priority needs proposal Need to make some design decisions debt Covers everything internal: CI, testing, refactoring of the codebase, etc. labels Dec 18, 2018
@brettcannon
Copy link
Member

#3535 turned out to be a similar issue where ENOENT was being thrown.

@DonJayamanne
Copy link
Author

That's a different issue, as the extension did activate (i.e. it didn't crash).
This issue is to track cases where extension falls over completely.

@DonJayamanne
Copy link
Author

Add telemetry to capture failure to load the extension.

@ericsnowcurrently ericsnowcurrently self-assigned this Jan 7, 2019
@ericsnowcurrently ericsnowcurrently mentioned this issue Jan 9, 2019
Merged
4 tasks
ericsnowcurrently added a commit that referenced this issue Jan 10, 2019
@ericsnowcurrently
gh-3740: Handle activation errors. (#3951)
27f485b 
(for #3740) Handle errors during extension activation.
@ghost ghost removed needs PR needs proposal Need to make some design decisions labels Jan 15, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Feb 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ericsnowcurrently ericsnowcurrently

Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc. important Issue identified as high-priority
Projects
None yet
Milestone
2019, week 1 - Jan Sprint 1
Development

No branches or pull requests
3 participants
@brettcannon @ericsnowcurrently @DonJayamanne