Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prompt to turn on Pylint if a pylintrc file is found #4941

Closed
brettcannon opened this issue Mar 26, 2019 · 4 comments
Closed

Prompt to turn on Pylint if a pylintrc file is found #4941

brettcannon opened this issue Mar 26, 2019 · 4 comments
Assignees
Labels
area-linting feature-request Request for new features or functionality

Comments

@brettcannon
Copy link
Member

This will be the only prompting under the language server.

@DonJayamanne
Copy link

DonJayamanne commented Mar 27, 2019

Prescribed solution:

  • Replace logic in isLinterAvailable method of linterAvailability.ts (src/client/linters/linterAvailability.ts) to check if the pylintrc file exists in the workspace folder

@ericsnowcurrently
Copy link
Member

I was able to verify that this is done:

  1. create a new folder with a simple spam.py in it
  2. open the folder (and file) in vscode
  3. select a Python interpreter/env that doesn't have pylint installed yet
  4. set "python.jediEnabled": false in the folder's (new) settings.json
  5. reload the window

Result: nothing happened

  1. create an empty ".pylintrc" in the folder
  2. reload the window

Result: prompted to install pylint

@ghost ghost removed the needs PR label Apr 8, 2019
@ericsnowcurrently ericsnowcurrently removed their assignment Apr 8, 2019
@DonJayamanne DonJayamanne reopened this Apr 10, 2019
@DonJayamanne
Copy link

DonJayamanne commented Apr 10, 2019

Changes required:

  • Change message to You have a pylintrc file in your workspace. Do you want to enable pylint? [Enable] [Not now] [Do not show again]
  • [Do not show again] - This applies to the current workspace
  • [Not now] applies to the current session

@DonJayamanne
Copy link

DonJayamanne commented Apr 18, 2019

This only works for .pylintrc & not for pylintrc.
Should support both file names.

@lock lock bot locked as resolved and limited conversation to collaborators May 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-linting feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

4 participants