Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate launching jupyter under docker #3504

Closed
IanMatthewHuff opened this issue Apr 1, 2019 · 1 comment
Closed

Investigate launching jupyter under docker #3504

IanMatthewHuff opened this issue Apr 1, 2019 · 1 comment
Assignees
@rchiodo

Comments

@IanMatthewHuff
Copy link
Member

Seems like we might need some more work here when launching juypter in a docker container. More specifically with regards to our local launch configuration.
@IanMatthewHuff
Copy link
Member Author

I was able to launch the notebook manually with these changes, but didn't fully investigate what else these changes might do and if they are ok to use in all local launch cases.

https://stackoverflow.com/questions/38830610/access-jupyter-notebook-running-on-docker-container

@rchiodo rchiodo self-assigned this Apr 4, 2019
rchiodo referenced this issue in microsoft/vscode-python Apr 5, 2019
@rchiodo
Fix running under docker (#5135)
e17c0d2 
For #5047

<!--
  If an item below does not apply to you, then go ahead and check it off as "done" and strikethrough the text, e.g.:
    - [x] ~Has unit tests & system/integration tests~
-->
- [x] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
- [x] Title summarizes what is changing
- [x] Has a [news entry](https://github.com/Microsoft/vscode-python/tree/master/news) file (remember to thank yourself!)
- [ ] Has sufficient logging.
- [ ] Has telemetry for enhancements.
- [ ] Unit tests & system/integration tests are added/updated
- [ ] [Test plan](https://github.com/Microsoft/vscode-python/blob/master/.github/test_plan.md) is updated as appropriate
- [ ] [`package-lock.json`](https://github.com/Microsoft/vscode-python/blob/master/package-lock.json) has been regenerated by running `npm install` (if dependencies have changed)
- [ ] The wiki is updated with any design decisions/details.
@rchiodo rchiodo closed this as completed Apr 24, 2019
@lock lock bot locked as resolved and limited conversation to collaborators May 22, 2019
@microsoft microsoft unlocked this conversation Nov 14, 2020
@DonJayamanne DonJayamanne transferred this issue from microsoft/vscode-python Nov 14, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rchiodo rchiodo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@IanMatthewHuff @rchiodo