Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cached list of interpreters should not be cleared #617

Closed
DonJayamanne opened this issue Jan 23, 2018 · 0 comments · Fixed by #621
Closed

Cached list of interpreters should not be cleared #617

DonJayamanne opened this issue Jan 23, 2018 · 0 comments · Fixed by #621
Assignees
@DonJayamanne
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Milestone
January 2018

Comments

@DonJayamanne
Copy link

The list of interpreters is cached today, however any changes to the configuration settings clears this cache.
This adversely affects the performance of creation of terminals (REPL, executing code in terminal, etc). (affects performance of #383)

  • Why we need this code that clears the cache?
@DonJayamanne DonJayamanne added awaiting 2-PR debt Covers everything internal: CI, testing, refactoring of the codebase, etc. labels Jan 23, 2018
@DonJayamanne DonJayamanne added this to the January 2018 milestone Jan 23, 2018
@DonJayamanne DonJayamanne self-assigned this Jan 23, 2018
@DonJayamanne DonJayamanne changed the title Cache list of interpreters Cached list of interpreters should not be cleared Jan 23, 2018
@DonJayamanne DonJayamanne mentioned this issue Jan 24, 2018
Merged
DonJayamanne added a commit that referenced this issue Jan 25, 2018
@DonJayamanne
Do not clear interpreter cache (#621)
60187ea 
Fixes #617
@brettcannon brettcannon mentioned this issue Jan 29, 2018
Closed
38 tasks
@lock lock bot locked as resolved and limited conversation to collaborators Jul 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DonJayamanne DonJayamanne

Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Projects
None yet
Milestone
January 2018
Development

Successfully merging a pull request may close this issue.

Do not clear interpreter cache DonJayamanne/pythonVSCode
2 participants
@brettcannon @DonJayamanne