Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change activation of conda environments in powershell #668

Closed
DonJayamanne opened this issue Jan 31, 2018 · 4 comments
Closed

Change activation of conda environments in powershell #668

DonJayamanne opened this issue Jan 31, 2018 · 4 comments
Assignees
Labels
area-terminal bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority windows

Comments

@DonJayamanne
Copy link

Once the upstream Conda Issue #626 is resolved, we'll need to update the conda activation accordingly.

@DonJayamanne DonJayamanne added awaiting 2-PR debt Covers everything internal: CI, testing, refactoring of the codebase, etc. area-terminal windows labels Jan 31, 2018
@kalefranz
Copy link

A contributed powershell wrapper to conda would be hugely appreciated. With conda 4.4+, there are five other shell wrappers for conda. We're still obviously missing powershell.

I started the conda/conda#6471 PR as a sketch of what the powershell wrapper might look like, and Steve Dower added some additional comments in conda/conda#6471 (comment).

Eager to work with anyone wanting to push this through and get it in.

@DonJayamanne DonJayamanne added important Issue identified as high-priority and removed important Issue identified as high-priority labels Oct 6, 2018
@DonJayamanne DonJayamanne added important Issue identified as high-priority and removed needs upstream fix labels Jan 30, 2019
@qubitron qubitron removed the debt Covers everything internal: CI, testing, refactoring of the codebase, etc. label Jan 30, 2019
@DonJayamanne DonJayamanne self-assigned this Jan 31, 2019
@DonJayamanne DonJayamanne removed their assignment Feb 13, 2019
@DonJayamanne DonJayamanne removed this from the 2019, week 5 - Jan Sprint 3 milestone Feb 27, 2019
@DonJayamanne
Copy link
Author

DonJayamanne commented Feb 27, 2019

Prescribed solution:

    public async getPowershellCommands(
        _envName: string,
        _targetShell: TerminalShellType
    ): Promise<string[] | undefined> {
        return;
    }
  • Modify to send the command conda activate xxx
  • Assumption - Powershell has been configured on user environment for conda.

@DonJayamanne DonJayamanne added bug Issue identified by VS Code Team member as probable bug needs PR labels Feb 28, 2019
@tonyxwz
Copy link

tonyxwz commented Mar 5, 2019

My current solution is to add the following to workspace setting,

{
"terminal.integrated.shellArgs.windows": [
        "-NoExit",
        "-Command",
        "conda activate pyHIFU"
    ],
    "python.terminal.activateEnvironment": false
}

where pyHIFU is my environment name.

@DonJayamanne DonJayamanne removed this from the 2019, week 9 - Feb Sprint 5 milestone Mar 13, 2019
@DonJayamanne DonJayamanne mentioned this issue Apr 17, 2019
24 tasks
@DonJayamanne DonJayamanne self-assigned this Apr 24, 2019
@karrtikr
Copy link

Given powershell has been configured on user environment for conda and conda activate <envName> works on powershell, validated.

@ghost ghost removed the needs PR label Jun 18, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-terminal bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority windows
Projects
None yet
Development

No branches or pull requests

7 participants