prevent svg icons

microsoft · Jun 23, 2017 · e0dff61 · e0dff61 · eamodio · Jun 25, 2017
1 parent 7cee285
commit e0dff61
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 0 deletions.
diff --git a/src/package.ts b/src/package.ts
@@ -502,6 +502,10 @@ export function validateManifest(manifest: Manifest): Manifest {
 
 	validateEngineCompatibility(manifest.engines['vscode']);
 
+	if (/\.svg$/i.test(manifest.icon || '')) {
+		throw new Error(`SVGs can't be used as icons: ${manifest.icon}`);
+	}
+
 	return manifest;
 }
 

diff --git a/src/test/package.test.ts b/src/test/package.test.ts
@@ -90,6 +90,17 @@ function assertMissingProperty(manifest: XMLManifest, name: string): void {
 	assert.equal(property.length, 0, `Property '${name}' should not exist`);
 }
 
+function createManifest(extra: Partial<Manifest>): Manifest {
+	return {
+		name: 'test',
+		publisher: 'mocha',
+		version: '0.0.1',
+		description: 'test extension',
+		engines: { vscode: '*' },
+		...extra
+	};
+}
+
 describe('collect', () => {
 
 	it('should catch all files', () => {
@@ -192,6 +203,11 @@ describe('validateManifest', () => {
 		assert.throws(() => { validateManifest({ publisher: 'demo', name: 'demo', version: '1.0.0', engines: null }); });
 		assert.throws(() => { validateManifest({ publisher: 'demo', name: 'demo', version: '1.0.0', engines: { vscode: null } }); });
 	});
+
+	it('should prevent SVG icons', () => {
+		assert(validateManifest(createManifest({ icon: 'icon.png' })));
+		assert.throws(() => { validateManifest(createManifest({ icon: 'icon.svg' })); });
+	});
 });
 
 describe('toVsixManifest', () => {