Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support to update breakpoint status asynchronously #2013

Closed
weinand opened this issue Jan 14, 2016 · 3 comments
Closed

Support to update breakpoint status asynchronously #2013

weinand opened this issue Jan 14, 2016 · 3 comments
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality verified Verification succeeded
Milestone

Comments

@weinand
Copy link
Contributor

weinand commented Jan 14, 2016

With the current breakpoint API it is only possible to return errors as part of the SetBreakpointsRequest, and there is no way to update that error message or clear it later on. Other debug adapters allow to set breakpoints before they know if they are valid and then want to update the UI as modules load and it can be determined if they have really bound or not.

The current thinking is that we will introduce a breakpoint ID and a BreakpointsUpdatedEvent.

CC @gregg-miskelly @isidorn

@weinand weinand added feature-request Request for new features or functionality debug Debug viewlet, configurations, breakpoints, adapter issues labels Jan 14, 2016
@weinand weinand self-assigned this Jan 14, 2016
@vadimcn
Copy link
Contributor

vadimcn commented Jan 14, 2016

Please consider also supporting "unsolicited" breakpoint notifications. It would be nice if breakpoints created via debugger's REPL interface could be displayed in the UI and be preserved across debugging sessions. (Note that this might require round-tripping a custom data chunk to account for advanced breakpoint attributes which VSCode does not know about.)

@weinand weinand modified the milestones: Backlog, Feb 2016 Jan 19, 2016
@egamma egamma mentioned this issue Feb 3, 2016
97 tasks
@weinand
Copy link
Contributor Author

weinand commented Feb 8, 2016

I've added the following protocol support: a new BreakpointEvent and an attribute id for the Breakpoint type. A debug adapter that wants to send out BreakpointEvent is expected to set the id of the Breakpoint returned from the setBreakpoints or setFunctionBreakpoints requests so that subsequent events with the same id can be mapped to the corresponding breakpoints.

@isidorn please implement this in the front end.

@weinand weinand assigned isidorn and unassigned weinand Feb 8, 2016
@weinand weinand added the verified Verification succeeded label Feb 10, 2016
@weinand
Copy link
Contributor Author

weinand commented Feb 10, 2016

@gregg-miskelly VS Code now listens on breakpoint events with reason update and updates the verification state and location.

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants