Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow contribute trees to better control collapse-on-click behaviour #45184

Closed
DanTup opened this issue Mar 7, 2018 · 2 comments
Closed

Allow contribute trees to better control collapse-on-click behaviour #45184

DanTup opened this issue Mar 7, 2018 · 2 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) tree-views Extension tree view issues

Comments

@DanTup
Copy link
Contributor

DanTup commented Mar 7, 2018

This isn't really a bug and it happens in the standard explorer tree, but it's undesirable when a tree node serves at two purposes (something that can can be selected for editing purposes and also expanded).

In this tree, I have items that can expand/collapse but also represent code in the main editor (for example AlertDialog is related to some code):

collapses

If I click on AlertTree to select it (which jumps the editor to its location) it also collapses the node. This is undesirable - the user wants to navigate to it - it doesn't make sense to hide its children.

I think there should be some ability on a TreeItem to control this behaviour (for example, I would prefer for it never to collapse on click, unless it was already selected).

I think it works ok in the File explorer tree because clicking on a folder is less useful (it doesn't navigate the editor) and therefore it doesn't happen as often as it would in an outline tree.

@isidorn isidorn assigned sandy081 and unassigned isidorn Mar 7, 2018
@sandy081 sandy081 added the tree-views Extension tree view issues label Mar 7, 2018
@sandy081
Copy link
Member

sandy081 commented Mar 7, 2018

Duplicate of #34130

@sandy081 sandy081 marked this as a duplicate of #34130 Mar 7, 2018
@sandy081 sandy081 added the *duplicate Issue identified as a duplicate of another issue(s) label Mar 7, 2018
@vscodebot
Copy link

vscodebot bot commented Mar 7, 2018

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for existing issues here. See also our issue reporting guidelines.

Happy Coding!

@vscodebot vscodebot bot closed this as completed Mar 7, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) tree-views Extension tree view issues
Projects
None yet
Development

No branches or pull requests

3 participants