Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to show multiple lines in a notification #48900

Closed
Misiur opened this issue Apr 28, 2018 · 2 comments
Closed

Allow to show multiple lines in a notification #48900

Misiur opened this issue Apr 28, 2018 · 2 comments
Labels
feature-request Request for new features or functionality workbench-notifications Notification widget issues

Comments

@Misiur
Copy link

Misiur commented Apr 28, 2018

I would like to display a few lines in my notifications, but I see that's explicitly forbidden:

https://github.com/Microsoft/vscode/blob/8616dbae8bc2abf7972a45449b0fb6b2b2d0f429/src/vs/workbench/common/notifications.ts#L412-L413

Is there some kind of low-level api access to display either non-link parsed raw string with new lines, or even allowing full html support?
@jrieken jrieken assigned bpasero and unassigned jrieken Apr 30, 2018
@bpasero bpasero added feature-request Request for new features or functionality workbench-notifications Notification widget issues labels Apr 30, 2018
@bpasero bpasero removed their assignment Apr 30, 2018
@bpasero bpasero changed the title Multiple lines in a notification Allow to show multiple lines in a notification Apr 30, 2018
@bpasero
Copy link
Member

bpasero commented Apr 30, 2018

Notifications are imho not the right place to show structured text with formatting. I do not think we would want to expose API to allow for newlines in notifications.

@bpasero
Copy link
Member

bpasero commented Sep 18, 2018

Closing due to #48900 (comment)

@bpasero bpasero closed this as completed Sep 18, 2018
@bpasero bpasero mentioned this issue Sep 18, 2018
Closed
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
feature-request Request for new features or functionality workbench-notifications Notification widget issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Misiur @bpasero @jrieken