Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intellisense does not pickup Typescript 3 references #57242

Closed
tommedema opened this issue Aug 27, 2018 · 1 comment
Closed

Intellisense does not pickup Typescript 3 references #57242

tommedema opened this issue Aug 27, 2018 · 1 comment
Assignees

Comments

@tommedema
Copy link

tommedema commented Aug 27, 2018

  • VSCode Version: 1.26.1
  • OS Version: OSX High Sierra

Steps to Reproduce:

  1. git clone git@github.com:tommedema/serverless-mono-example.git
  2. cd serverless-mono-example && yarn install && code .
  3. if you change a typing in package random, it is not picked up by intellisense in typescript packages that reference to it in the same workspace (e.g. sls-random); you'd have to compile first

for example, change fetchRandomNumber in random to return a Promise<string>, and sls-random still expects a Promise<number>

Note that sls-random is connected with random through Typescript 3 references:

{
  "extends": "../../tsconfig.settings.json",
  "compilerOptions": {
    "outDir": "dist",
    "rootDir": "src"
  },
  "references": [
    { "path": "../random" }
  ]
}

And therefore intellisense should pickup the referenced typings dynamically.

Does this issue occur when all extensions are disabled?: Yes

@mjbvz
Copy link
Collaborator

mjbvz commented Sep 5, 2018

This issue was moved to microsoft/TypeScript#26913

@mjbvz mjbvz closed this as completed Sep 5, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants
@joaomoreno @tommedema @mjbvz and others