wrong indentation detection for python

[beantowel]

Issue Type: Bug

open a file including these line:

def foo(bars):
    for bar in bars:
        pass

vs code will detect the indentation as Spaces: 8, where the correct indentation setting should be 4 spaces.

VS Code version: Code 1.28.2 (7f3ce96, 2018-10-17T00:20:56.183Z)
OS version: Linux x64 4.15.0-38-lowlatency

Extensions (13)

Extension	Author (truncated)	Version
code-gnu-global	aus	0.2.2
thrift	cdu	0.0.1
vscode-markdownlint	Dav	0.21.0
code-runner	for	0.9.5
latex-workshop	Jam	5.13.0
racket	kar	0.0.3
vscode-clang	mit	0.2.3
anaconda-extension-pack	ms-	1.0.1
python	ms-	2018.9.2
cpptools	ms-	0.20.1
vscode-yaml	red	0.0.17
cmake	twx	0.0.17
clang-format	xav	1.6.2

[vscodebot]

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

• Detect Indention from Content does not detect 2 spaces in a new file and requires a reload of the file (#40828)
• Detect Indentation setting removes single space on indent (#61442)
• Convert width of space indentation (#17802)
• indenation (#59180)

[kieferrm]

The auto indentation rules come from the Python extension. Please file the issue there: https://github.com/Microsoft/vscode-python/issues. Thanks!

[vscodebot]

This issue is caused by an extension, please file it with the repository (or contact) the extension has linked in its overview in VS Code or the marketplace for VS Code. See also our issue reporting guidelines.

Happy Coding!

[beantowel]

The auto indentation rules come from the Python extension. Please file the issue there: https://github.com/Microsoft/vscode-python/issues. Thanks!

i've tried disable all the extensions and reload the window, the problem still there.

[ccaspers]

The auto indentation rules come from the Python extension. Please file the issue there: https://github.com/Microsoft/vscode-python/issues. Thanks!

i've tried disable all the extensions and reload the window, the problem still there.

Same here. The detected indentation is wrong, regardless of the python extension being enabled or not.

[noinkling]

I'm encountering a very similar (probably the same) issue in markdown: #65043

[teodorlu]

I'm also encountering this issue.

• VS Code deduces 8 spaces per indentation for source files with 4 spaces per indentation
• I do not have the vscode-python extension installed
• code -version: 1.32.3 a3db5be x64

import contextlib


@contextlib.contextmanager
def readonly_odb(odbpath):
    import odbAccess
    odb = odbAccess.openOdb(path=odbpath, readOnly=True)
    try:
        yield odb
    finally:
        odb.close()


def testodb(odbpath):
    import odbAccess
    with readonly_odb(odbpath) as odb:
        pass


def main():
    testodb(r"C:\temp\smalloutput\BF-K11_004-p03_d90_2019-03-10.odb")
    pass

[prof7bit]

This does not trigger the bug, it is detected as 4 spaces:

class Foo:
    def bar(self):
        pass

This does trigger the bug and is detected as 8 spaces:

def foo():
    for i in range(3):
        print(i)

All extensions are disabled.

It is the parenthesis on the first line that makes the difference! If I remove the () from the "def foo():" then without changing anything else it would correctly detect it as 4 spaces!

[lucasgcb]

It is the parenthesis on the first line that makes the difference! If I remove the () from the "def foo():" then without changing anything else it would correctly detect it as 4 spaces!

Can confirm. All my pytest files are quite annoying to deal with because of this.

[JackLiar]

please fix this problem, it's really annoying...... :(

[JackLiar]

on macOS 10.14.4/Ubuntu 17.04, vscode 1.33.1

def foo:
    for i in range(3):
        print(i)

is wrong too

[head-wired]

I have the same problem (Win 10 1809) vscode 1.33.1
automatic indentation is always a multiple of 8 (instead of 4) when pressing enter and going to a new line that requires an indentation change.

I'm pretty sure this worked correctly in the past.

[nuumio]

Just ran into this with 1.34.0 on Ubuntu 18.04.2. Quite annoying especially in Python. I disabled all extensions and it still happens.

Version: 1.34.0
Commit: a622c65
Date: 2019-05-15T21:55:35.507Z
Electron: 3.1.8
Chrome: 66.0.3359.181
Node.js: 10.2.0
V8: 6.6.346.32
OS: Linux x64 4.15.0-50-generic

To reproduce create foo.py and write (with indent of 4 spaces):

def foo():
    if True:
        pass

Save, close and re-open foo.py. Add function bar() and indent is 8 spaces.

def foo():
    if True:
        pass

def bar():
        if True:
                pass

Workaround: Disable Editor: Detect Indentation.

[JAAdrian]

Just ran into this with 1.34.0 on Ubuntu 18.04.2. Quite annoying especially in Python. I disabled all extensions and it still happens.

Version: 1.34.0
Commit: a622c65
Date: 2019-05-15T21:55:35.507Z
Electron: 3.1.8
Chrome: 66.0.3359.181
Node.js: 10.2.0
V8: 6.6.346.32
OS: Linux x64 4.15.0-50-generic

To reproduce create foo.py and write (with indent of 4 spaces):

def foo():
    if True:
        pass

Save, close and re-open foo.py. Add function bar() and indent is 8 spaces.

def foo():
    if True:
        pass

def bar():
        if True:
                pass

Workaround: Disable Editor: Detect Indentation.

I can confirm the same behavior on my side.

Version: 1.36.0
OS: Linux Mint 19 x64 5.0.0-20-generic

[rebornix]

Close in favor of #62143, which is fixed in master already.