Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OSC section on "Console Virtual Terminal Sequences" to include updated string terminators #120

Closed
zadjii-msft opened this issue Jan 8, 2020 · 3 comments · Fixed by #221
Labels
Help-Wanted We encourage anyone to jump in on these. Research-Required Needs someone to go check the inbox code to line it up with the doc Size-Medium A few paragraphs

Comments

@zadjii-msft
Copy link
Contributor

In ColorTool I see we use BEL as OSC end. I believe it aligns with xterm.
string s = $"\x1b]4;{vtIndex};rgb:{color.R:X}/{color.G:X}/{color.B:X}\x7"
https://github.com/microsoft/terminal/blob/master/src/tools/ColorTool/ColorTool/ConsoleTargets/VirtualTerminalConsoleTarget.cs
but in the doc, it says ESC as end
I think it wants to say "ESC ", which is ST

We should make sure specifically the string terminators for the OSC section get updated.

(subset of #91)


Document Details

Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

@bef178
Copy link

bef178 commented Jan 10, 2020

Typo:

I think it wants to say "ESC \", which is ST

@miniksa miniksa added Research-Required Needs someone to go check the inbox code to line it up with the doc Size-Medium A few paragraphs Help-Wanted We encourage anyone to jump in on these. labels Feb 13, 2020
@miniksa
Copy link
Collaborator

miniksa commented Feb 13, 2020

This could be cross-referenced by anyone against the code in the Microsoft/Terminal repo.

@KalleOlaviNiemitalo
Copy link

KalleOlaviNiemitalo commented Feb 17, 2020

bool _isOscTerminator(wchar_t) supports either BEL or single-character (U+009C) ST as the terminator after OSC.

bool _isOscTerminationInitiator(wchar_t) recognizes the first character of the two-character (ESC 0x5C) representation of ST, and void StateMachine::_EventOscTermination(wchar_t) then behaves as if the second character were 0x5C but does not check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help-Wanted We encourage anyone to jump in on these. Research-Required Needs someone to go check the inbox code to line it up with the doc Size-Medium A few paragraphs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants