Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding the developer mode requirement to PWA widgets doc #2800

Merged
merged 3 commits into from
Aug 28, 2023
Merged

Adding the developer mode requirement to PWA widgets doc #2800

merged 3 commits into from
Aug 28, 2023

Conversation

captainbrosset
Copy link
Contributor

@captainbrosset captainbrosset commented Aug 24, 2023 •
edited
Loading

@captainbrosset captainbrosset added the cat: pwas Progressive Web Apps-related content label Aug 24, 2023
amandabaker
amandabaker reviewed Aug 24, 2023
View reviewed changes
Copy link
Contributor

@amandabaker amandabaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside from the one comment

microsoft-edge/progressive-web-apps-chromium/how-to/widgets.md Outdated Show resolved Hide resolved
@learn-build-service-prod
Copy link

Learn Build status updates of commit 2b8f5ce:

✅ Validation status: passed

File Status Preview URL Details
microsoft-edge/progressive-web-apps-chromium/how-to/widgets.md ✅Succeeded View
microsoft-edge/progressive-web-apps-chromium/how-to/widgets-images/developer-mode.png ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

amandabaker
amandabaker approved these changes Aug 25, 2023
View reviewed changes
Copy link
Contributor

@amandabaker amandabaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for getting this updated!

@captainbrosset captainbrosset merged commit 4246ab0 into main Aug 28, 2023
1 check passed
@captainbrosset captainbrosset deleted the user/pabrosse/widget-dev-mode branch August 28, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikehoffms mikehoffms mikehoffms approved these changes

@amandabaker amandabaker amandabaker approved these changes

Assignees
No one assigned
Labels
cat: pwas Progressive Web Apps-related content
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@captainbrosset @amandabaker @mikehoffms