Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 | key_capability parameter in Generic_USB is never used #2381

Closed
s-martin opened this issue Jun 3, 2024 · 1 comment · Fixed by #2382
Closed

🐛 | key_capability parameter in Generic_USB is never used #2381

s-martin opened this issue Jun 3, 2024 · 1 comment · Fixed by #2382
Assignees
@s-martin
Labels
bug future3 Relates to future3 development
Milestone
v3.6

Comments

@s-martin
Copy link
Collaborator

s-martin commented Jun 3, 2024 •
edited
Loading

Version

future3/develop

Branch

future3/develop

OS

Bullseye Lite 32 Bit

Pi model

RPi 3B

Hardware

Generic USB reader

What happened?

I got the warning

03.06.2024 00:06:23 -   20:readerbase.py      - jb.rfid.usb(read_00) - read_00Thread   - DEBUG    - Reader object is <components.rfid.hardware.generic_usb.generic_usb.ReaderClass object at 0x6128ef70> for reader config key 'read_00'
03.06.2024 00:06:23 -  144:generic_usb.py     - jb.rfid.usb(read_00) - read_00Thread   - WARNING  - Key 'key_capability' not given in configuration! Using default value: 'true'.

in my logs.

While checking for the issue I realized that while this parameter is read here (and set to default true) it is used nowhere.

RPi-Jukebox-RFID/src/jukebox/components/rfid/hardware/generic_usb/generic_usb.py

Lines 143 to 144 in 2232a35

if 'key_capability' not in config:
self._logger.warning("Key 'key_capability' not given in configuration! Using default value: 'true'.")

I suggest to remove reading this parameter.
@s-martin s-martin added bug needs triage future3 Relates to future3 development labels Jun 3, 2024
@s-martin s-martin self-assigned this Jun 3, 2024
@s-martin s-martin added this to the v3.6 milestone Jun 3, 2024
@s-martin s-martin mentioned this issue Jun 4, 2024
Merged
@s-martin s-martin linked a pull request Jun 4, 2024 that will close this issue
(maint) Remove unused read of parameter #2382
Merged
@s-martin
Copy link
Collaborator Author

s-martin commented Jun 5, 2024

Implemented in #2382

@s-martin s-martin closed this as completed Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@s-martin s-martin

Labels
bug future3 Relates to future3 development
Projects
None yet
Milestone
v3.6
Development

Successfully merging a pull request may close this issue.

(maint) Remove unused read of parameter s-martin/RPi-Jukebox-RFID
1 participant
@s-martin