-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove or modify EventArray._getBlockIndexWith*() methods #22
Comments
Note: Removing the End of a traceback in which the issue occurred:
|
Correction: the previous comment has not been resolved, it is just sporadic. For some reason, |
The new implementations of
EventArray._getBlockIndexWithIndex()
andEventArray_GetBlockIndexWithTime()
are somewhat slower than the original. There's a comment in the code reading "profile & determine if this change is beneficial." Here are times using the oldEventList
methods (EventArray
versions commented out):The
EventArray
version:(I did notice that the latter was called 8% more often, but the time differences are greater than that.)
This is probably because theEventArray
version does a search of all blocks every time. TheEventList
version caches groups of times and indices, making the search smaller set to search.The text was updated successfully, but these errors were encountered: