Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scale and/or compute better Channel.displayRange #91

Open
StokesMIDE opened this issue Oct 6, 2021 · 0 comments
Open

Scale and/or compute better Channel.displayRange #91

StokesMIDE opened this issue Oct 6, 2021 · 0 comments
Labels
calibration Related to the generation or application of `Transform` function enhancement New feature or request

Comments

@StokesMIDE
Copy link
Member

The Channel objects' displayRange attribute is currently set using parsers.getParserRanges(). There are two problems with this:
the data is not scaled to engineering units, and it uses the maximum range of the value in the parser's struct, which is incorrect (particularly for digital sensors).

The is also set up to use values from the <SubChannel> elements <SubChannelRangeMin> and <SubChannelRangeMax>, but as of 10/2021, those are not being written.

Two things that can be done:

  • Scale the output from getParserRanges() from internal units to engineering units (note: exclude the per-channel calibration)
  • Keep a set of hardcoded min/max for different sensors.

Some of the latter has been implemented for endaqlib (not yet released); the functionality can be moved into idelib.

@StokesMIDE StokesMIDE added enhancement New feature or request calibration Related to the generation or application of `Transform` function labels Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
calibration Related to the generation or application of `Transform` function enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant