Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outline selection example not working #11

Open
Simi4 opened this issue Jun 26, 2018 · 6 comments
Open

Outline selection example not working #11

Simi4 opened this issue Jun 26, 2018 · 6 comments

Comments

@Simi4
Copy link

Simi4 commented Jun 26, 2018

default

Tested with:
Intel HD 4400
OpenGL 4.3 CoreProfile
Qt 5.10

the log is empty

@Simi4
Copy link
Author

Simi4 commented Jul 9, 2018

@florianblume
Copy link

I know this is a rather old issue but looking at the framegraph this is actually exactly the image I would expect. In the code, first the objects are all drawn and then in line 60 both the depth AND the color buffer are cleared. I can't get the whole project to run at the moment but I suspect that if you change that part to depth buffer only you should get the correct result.

@MidoriYakumo
Copy link
Owner

Thank you nice fellows found this problem in this repo.
My answer is YES, what you see now is what I saw the moment I write these codes, and I think there are BUGs on QT side and I cannot fix it at the moment(tried several parameter combinations, reading and debugging QT codes), if there is anyway to fix it now, I'm very appreciated to receive such a PR. 😇

@MidoriYakumo
Copy link
Owner

I saw Sean Harmer replied you in maillist, does LayerFilter works?

@florianblume
Copy link

florianblume commented Jul 11, 2022

I cannot recall which e-mail by him you mean but LayerFitler does work, for me the reason when it didn't work was that I forgot to set recursive to true ;)

Unfortunately, I don't get where you got the assets from that's why I cannot launch it but like I said I think your clear buffers are wrong:

In file stencil_testing.qml line 60 should not clear the color buffer, only the depth buffer (and not also stencil like I first said). This part of the code will be executed after the first render surface selector which will clear the buffer after the objects have been drawn.

@MidoriYakumo
Copy link
Owner

@florianblume All assets from https://learnopengl.com/

I'm happy to receive PR if it can be fixed

Stencil-testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants