Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[X64] [Sergio0694] Intrinsify typeof(T).IsGenericType #227

Open
MihuBot opened this issue Jan 20, 2024 · 1 comment
Open

[X64] [Sergio0694] Intrinsify typeof(T).IsGenericType #227

MihuBot opened this issue Jan 20, 2024 · 1 comment

Comments

@MihuBot
Copy link
Owner

MihuBot commented Jan 20, 2024

Build completed in 1 hour 43 minutes.
dotnet/runtime#97148

CoreLib diffs

Found 1 files with textual diffs.

Summary of Code Size diffs:
(Lower is better)

Total bytes of base: 7266462
Total bytes of diff: 7266462
Total bytes of delta: 0 (0.00 % of base)


0 total files with Code Size differences (0 improved, 0 regressed), 1 unchanged.

0 total methods with Code Size differences (0 improved, 0 regressed), 55527 unchanged.

--------------------------------------------------------------------------------

Frameworks diffs

Diffs
Found 261 files with textual diffs.

Summary of Code Size diffs:
(Lower is better)

Total bytes of base: 38616574
Total bytes of diff: 38613700
Total bytes of delta: -2874 (-0.01 % of base)
Total relative delta: -6.42
    diff is an improvement.
    relative diff is an improvement.


Top file improvements (bytes):
       -1679 : System.Text.Json.dasm (-0.13 % of base)
       -1161 : System.Data.Common.dasm (-0.07 % of base)
         -34 : System.Private.DataContractSerialization.dasm (-0.00 % of base)

3 total files with Code Size differences (3 improved, 0 regressed), 253 unchanged.

Top method improvements (bytes):
        -196 (-23.33 % of base) : System.Text.Json.dasm - System.Text.Json.Serialization.Metadata.JsonTypeInfo:CreateJsonTypeInfo[double](System.Text.Json.JsonSerializerOptions):System.Text.Json.Serialization.Metadata.JsonTypeInfo`1[double] (FullOpts)
        -196 (-23.33 % of base) : System.Text.Json.dasm - System.Text.Json.Serialization.Metadata.JsonTypeInfo:CreateJsonTypeInfo[int](System.Text.Json.JsonSerializerOptions):System.Text.Json.Serialization.Metadata.JsonTypeInfo`1[int] (FullOpts)
        -196 (-23.33 % of base) : System.Text.Json.dasm - System.Text.Json.Serialization.Metadata.JsonTypeInfo:CreateJsonTypeInfo[long](System.Text.Json.JsonSerializerOptions):System.Text.Json.Serialization.Metadata.JsonTypeInfo`1[long] (FullOpts)
        -196 (-23.33 % of base) : System.Text.Json.dasm - System.Text.Json.Serialization.Metadata.JsonTypeInfo:CreateJsonTypeInfo[short](System.Text.Json.JsonSerializerOptions):System.Text.Json.Serialization.Metadata.JsonTypeInfo`1[short] (FullOpts)
        -196 (-23.33 % of base) : System.Text.Json.dasm - System.Text.Json.Serialization.Metadata.JsonTypeInfo:CreateJsonTypeInfo[ubyte](System.Text.Json.JsonSerializerOptions):System.Text.Json.Serialization.Metadata.JsonTypeInfo`1[ubyte] (FullOpts)
        -127 (-45.52 % of base) : System.Data.Common.dasm - System.Data.DataRowExtensions+UnboxT`1[double]:<Create>g__CreateWhenDynamicCodeSupported|1_0():System.Func`2[System.Object,double] (FullOpts)
        -127 (-45.52 % of base) : System.Data.Common.dasm - System.Data.DataRowExtensions+UnboxT`1[int]:<Create>g__CreateWhenDynamicCodeSupported|1_0():System.Func`2[System.Object,int] (FullOpts)
        -127 (-45.52 % of base) : System.Data.Common.dasm - System.Data.DataRowExtensions+UnboxT`1[long]:<Create>g__CreateWhenDynamicCodeSupported|1_0():System.Func`2[System.Object,long] (FullOpts)
        -127 (-45.52 % of base) : System.Data.Common.dasm - System.Data.DataRowExtensions+UnboxT`1[short]:<Create>g__CreateWhenDynamicCodeSupported|1_0():System.Func`2[System.Object,short] (FullOpts)
        -127 (-45.52 % of base) : System.Data.Common.dasm - System.Data.DataRowExtensions+UnboxT`1[ubyte]:<Create>g__CreateWhenDynamicCodeSupported|1_0():System.Func`2[System.Object,ubyte] (FullOpts)
        -107 (-32.82 % of base) : System.Text.Json.dasm - System.Text.Json.Serialization.JsonConverter:CreateCastingConverter[double]():System.Text.Json.Serialization.JsonConverter`1[double]:this (FullOpts)
        -107 (-32.82 % of base) : System.Text.Json.dasm - System.Text.Json.Serialization.JsonConverter:CreateCastingConverter[int]():System.Text.Json.Serialization.JsonConverter`1[int]:this (FullOpts)
        -107 (-32.82 % of base) : System.Text.Json.dasm - System.Text.Json.Serialization.JsonConverter:CreateCastingConverter[long]():System.Text.Json.Serialization.JsonConverter`1[long]:this (FullOpts)
        -107 (-32.82 % of base) : System.Text.Json.dasm - System.Text.Json.Serialization.JsonConverter:CreateCastingConverter[short]():System.Text.Json.Serialization.JsonConverter`1[short]:this (FullOpts)
        -107 (-32.82 % of base) : System.Text.Json.dasm - System.Text.Json.Serialization.JsonConverter:CreateCastingConverter[ubyte]():System.Text.Json.Serialization.JsonConverter`1[ubyte]:this (FullOpts)
         -90 (-15.99 % of base) : System.Data.Common.dasm - System.Data.DataRowExtensions+UnboxT`1[double]:NullableFieldUsingReflection(System.Object):double (FullOpts)
         -90 (-16.19 % of base) : System.Data.Common.dasm - System.Data.DataRowExtensions+UnboxT`1[int]:NullableFieldUsingReflection(System.Object):int (FullOpts)
         -90 (-16.16 % of base) : System.Data.Common.dasm - System.Data.DataRowExtensions+UnboxT`1[long]:NullableFieldUsingReflection(System.Object):long (FullOpts)
         -90 (-16.13 % of base) : System.Data.Common.dasm - System.Data.DataRowExtensions+UnboxT`1[short]:NullableFieldUsingReflection(System.Object):short (FullOpts)
         -90 (-16.16 % of base) : System.Data.Common.dasm - System.Data.DataRowExtensions+UnboxT`1[ubyte]:NullableFieldUsingReflection(System.Object):ubyte (FullOpts)
         -47 (-5.60 % of base) : System.Text.Json.dasm - System.Text.Json.Serialization.Metadata.JsonTypeInfo:CreateJsonTypeInfo[System.Nullable`1[int]](System.Text.Json.JsonSerializerOptions):System.Text.Json.Serialization.Metadata.JsonTypeInfo`1[System.Nullable`1[int]] (FullOpts)
         -47 (-5.60 % of base) : System.Text.Json.dasm - System.Text.Json.Serialization.Metadata.JsonTypeInfo:CreateJsonTypeInfo[System.Numerics.Vector`1[float]](System.Text.Json.JsonSerializerOptions):System.Text.Json.Serialization.Metadata.JsonTypeInfo`1[System.Numerics.Vector`1[float]] (FullOpts)
         -35 (-10.74 % of base) : System.Text.Json.dasm - System.Text.Json.Serialization.JsonConverter:CreateCastingConverter[System.Nullable`1[int]]():System.Text.Json.Serialization.JsonConverter`1[System.Nullable`1[int]]:this (FullOpts)
         -35 (-10.74 % of base) : System.Text.Json.dasm - System.Text.Json.Serialization.JsonConverter:CreateCastingConverter[System.Numerics.Vector`1[float]]():System.Text.Json.Serialization.JsonConverter`1[System.Numerics.Vector`1[float]]:this (FullOpts)
         -34 (-0.64 % of base) : System.Private.DataContractSerialization.dasm - System.Runtime.Serialization.DataContracts.CollectionDataContract:IsCollectionOrTryCreate(System.Type,ubyte,byref,byref,ubyte,ubyte):ubyte (FullOpts)
         -19 (-6.81 % of base) : System.Data.Common.dasm - System.Data.DataRowExtensions+UnboxT`1[System.Nullable`1[int]]:<Create>g__CreateWhenDynamicCodeSupported|1_0():System.Func`2[System.Object,System.Nullable`1[int]] (FullOpts)
         -19 (-3.27 % of base) : System.Data.Common.dasm - System.Data.DataRowExtensions+UnboxT`1[System.Nullable`1[int]]:NullableFieldUsingReflection(System.Object):System.Nullable`1[int] (FullOpts)
         -19 (-6.81 % of base) : System.Data.Common.dasm - System.Data.DataRowExtensions+UnboxT`1[System.Numerics.Vector`1[float]]:<Create>g__CreateWhenDynamicCodeSupported|1_0():System.Func`2[System.Object,System.Numerics.Vector`1[float]] (FullOpts)
         -19 (-3.02 % of base) : System.Data.Common.dasm - System.Data.DataRowExtensions+UnboxT`1[System.Numerics.Vector`1[float]]:NullableFieldUsingReflection(System.Object):System.Numerics.Vector`1[float] (FullOpts)

Top method improvements (percentages):
        -127 (-45.52 % of base) : System.Data.Common.dasm - System.Data.DataRowExtensions+UnboxT`1[double]:<Create>g__CreateWhenDynamicCodeSupported|1_0():System.Func`2[System.Object,double] (FullOpts)
        -127 (-45.52 % of base) : System.Data.Common.dasm - System.Data.DataRowExtensions+UnboxT`1[int]:<Create>g__CreateWhenDynamicCodeSupported|1_0():System.Func`2[System.Object,int] (FullOpts)
        -127 (-45.52 % of base) : System.Data.Common.dasm - System.Data.DataRowExtensions+UnboxT`1[long]:<Create>g__CreateWhenDynamicCodeSupported|1_0():System.Func`2[System.Object,long] (FullOpts)
        -127 (-45.52 % of base) : System.Data.Common.dasm - System.Data.DataRowExtensions+UnboxT`1[short]:<Create>g__CreateWhenDynamicCodeSupported|1_0():System.Func`2[System.Object,short] (FullOpts)
        -127 (-45.52 % of base) : System.Data.Common.dasm - System.Data.DataRowExtensions+UnboxT`1[ubyte]:<Create>g__CreateWhenDynamicCodeSupported|1_0():System.Func`2[System.Object,ubyte] (FullOpts)
        -107 (-32.82 % of base) : System.Text.Json.dasm - System.Text.Json.Serialization.JsonConverter:CreateCastingConverter[double]():System.Text.Json.Serialization.JsonConverter`1[double]:this (FullOpts)
        -107 (-32.82 % of base) : System.Text.Json.dasm - System.Text.Json.Serialization.JsonConverter:CreateCastingConverter[int]():System.Text.Json.Serialization.JsonConverter`1[int]:this (FullOpts)
        -107 (-32.82 % of base) : System.Text.Json.dasm - System.Text.Json.Serialization.JsonConverter:CreateCastingConverter[long]():System.Text.Json.Serialization.JsonConverter`1[long]:this (FullOpts)
        -107 (-32.82 % of base) : System.Text.Json.dasm - System.Text.Json.Serialization.JsonConverter:CreateCastingConverter[short]():System.Text.Json.Serialization.JsonConverter`1[short]:this (FullOpts)
        -107 (-32.82 % of base) : System.Text.Json.dasm - System.Text.Json.Serialization.JsonConverter:CreateCastingConverter[ubyte]():System.Text.Json.Serialization.JsonConverter`1[ubyte]:this (FullOpts)
        -196 (-23.33 % of base) : System.Text.Json.dasm - System.Text.Json.Serialization.Metadata.JsonTypeInfo:CreateJsonTypeInfo[double](System.Text.Json.JsonSerializerOptions):System.Text.Json.Serialization.Metadata.JsonTypeInfo`1[double] (FullOpts)
        -196 (-23.33 % of base) : System.Text.Json.dasm - System.Text.Json.Serialization.Metadata.JsonTypeInfo:CreateJsonTypeInfo[int](System.Text.Json.JsonSerializerOptions):System.Text.Json.Serialization.Metadata.JsonTypeInfo`1[int] (FullOpts)
        -196 (-23.33 % of base) : System.Text.Json.dasm - System.Text.Json.Serialization.Metadata.JsonTypeInfo:CreateJsonTypeInfo[long](System.Text.Json.JsonSerializerOptions):System.Text.Json.Serialization.Metadata.JsonTypeInfo`1[long] (FullOpts)
        -196 (-23.33 % of base) : System.Text.Json.dasm - System.Text.Json.Serialization.Metadata.JsonTypeInfo:CreateJsonTypeInfo[short](System.Text.Json.JsonSerializerOptions):System.Text.Json.Serialization.Metadata.JsonTypeInfo`1[short] (FullOpts)
        -196 (-23.33 % of base) : System.Text.Json.dasm - System.Text.Json.Serialization.Metadata.JsonTypeInfo:CreateJsonTypeInfo[ubyte](System.Text.Json.JsonSerializerOptions):System.Text.Json.Serialization.Metadata.JsonTypeInfo`1[ubyte] (FullOpts)
         -90 (-16.19 % of base) : System.Data.Common.dasm - System.Data.DataRowExtensions+UnboxT`1[int]:NullableFieldUsingReflection(System.Object):int (FullOpts)
         -90 (-16.16 % of base) : System.Data.Common.dasm - System.Data.DataRowExtensions+UnboxT`1[long]:NullableFieldUsingReflection(System.Object):long (FullOpts)
         -90 (-16.16 % of base) : System.Data.Common.dasm - System.Data.DataRowExtensions+UnboxT`1[ubyte]:NullableFieldUsingReflection(System.Object):ubyte (FullOpts)
         -90 (-16.13 % of base) : System.Data.Common.dasm - System.Data.DataRowExtensions+UnboxT`1[short]:NullableFieldUsingReflection(System.Object):short (FullOpts)
         -90 (-15.99 % of base) : System.Data.Common.dasm - System.Data.DataRowExtensions+UnboxT`1[double]:NullableFieldUsingReflection(System.Object):double (FullOpts)
         -35 (-10.74 % of base) : System.Text.Json.dasm - System.Text.Json.Serialization.JsonConverter:CreateCastingConverter[System.Nullable`1[int]]():System.Text.Json.Serialization.JsonConverter`1[System.Nullable`1[int]]:this (FullOpts)
         -35 (-10.74 % of base) : System.Text.Json.dasm - System.Text.Json.Serialization.JsonConverter:CreateCastingConverter[System.Numerics.Vector`1[float]]():System.Text.Json.Serialization.JsonConverter`1[System.Numerics.Vector`1[float]]:this (FullOpts)
         -19 (-6.81 % of base) : System.Data.Common.dasm - System.Data.DataRowExtensions+UnboxT`1[System.Nullable`1[int]]:<Create>g__CreateWhenDynamicCodeSupported|1_0():System.Func`2[System.Object,System.Nullable`1[int]] (FullOpts)
         -19 (-6.81 % of base) : System.Data.Common.dasm - System.Data.DataRowExtensions+UnboxT`1[System.Numerics.Vector`1[float]]:<Create>g__CreateWhenDynamicCodeSupported|1_0():System.Func`2[System.Object,System.Numerics.Vector`1[float]] (FullOpts)
         -47 (-5.60 % of base) : System.Text.Json.dasm - System.Text.Json.Serialization.Metadata.JsonTypeInfo:CreateJsonTypeInfo[System.Nullable`1[int]](System.Text.Json.JsonSerializerOptions):System.Text.Json.Serialization.Metadata.JsonTypeInfo`1[System.Nullable`1[int]] (FullOpts)
         -47 (-5.60 % of base) : System.Text.Json.dasm - System.Text.Json.Serialization.Metadata.JsonTypeInfo:CreateJsonTypeInfo[System.Numerics.Vector`1[float]](System.Text.Json.JsonSerializerOptions):System.Text.Json.Serialization.Metadata.JsonTypeInfo`1[System.Numerics.Vector`1[float]] (FullOpts)
         -19 (-3.27 % of base) : System.Data.Common.dasm - System.Data.DataRowExtensions+UnboxT`1[System.Nullable`1[int]]:NullableFieldUsingReflection(System.Object):System.Nullable`1[int] (FullOpts)
         -19 (-3.02 % of base) : System.Data.Common.dasm - System.Data.DataRowExtensions+UnboxT`1[System.Numerics.Vector`1[float]]:NullableFieldUsingReflection(System.Object):System.Numerics.Vector`1[float] (FullOpts)
         -34 (-0.64 % of base) : System.Private.DataContractSerialization.dasm - System.Runtime.Serialization.DataContracts.CollectionDataContract:IsCollectionOrTryCreate(System.Type,ubyte,byref,byref,ubyte,ubyte):ubyte (FullOpts)

29 total methods with Code Size differences (29 improved, 0 regressed), 236591 unchanged.

--------------------------------------------------------------------------------

Artifacts:

@MihuBot
Copy link
Owner Author

MihuBot commented Jan 20, 2024

@MihaZupan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant