Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GD-23: Add parameter to make Report Upload/Publishing optional #23

Closed
kdavis opened this issue Mar 30, 2024 · 0 comments · Fixed by #22
Closed

GD-23: Add parameter to make Report Upload/Publishing optional #23

kdavis opened this issue Mar 30, 2024 · 0 comments · Fixed by #22
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@kdavis
Copy link
Contributor

kdavis commented Mar 30, 2024

Is your feature request related to a problem? Please describe.
I'd like to be able to disable the publishing of artifacts for the test runner, but still have the tests run to see a pass/fail.

Describe the solution you'd like
A property in the with section, like "upload-report" which takes a true/false (or optionally, a github var like ${{ github.event.pull_request.draft == false }}

    - uses: MikeSchulze/gdUnit4-action@v1
      with:
        godot-version: '4.2.1'
        godot-status: 'stable'
        upload-report: false

Describe alternatives you've considered
N/A

Additional context
N/A

@kdavis kdavis added the enhancement New feature or request label Mar 30, 2024
@MikeSchulze MikeSchulze added this to the v1.0.5 milestone Mar 30, 2024
@MikeSchulze MikeSchulze linked a pull request Mar 30, 2024 that will close this issue
@MikeSchulze MikeSchulze changed the title Optional Report Upload/Publishing GD-23: Add parameter to make Report Upload/Publishing optional Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants