Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No way to tell if DANE part passed or not for cert usage 1 #136

Open
singpolyma opened this issue Feb 14, 2024 · 0 comments
Open

No way to tell if DANE part passed or not for cert usage 1 #136

singpolyma opened this issue Feb 14, 2024 · 0 comments

Comments

@singpolyma
Copy link

return tlsa.certUsage == TLSA.CertUsage.domainIssuedCertificate;

So for exmaple for 1 1 1 this checks that the DANE part passes, but then returns false because DANE is necessary but not sufficient in that case. We can know DANE didn't specifically fail because no exception is raised, but if DNSSEC fails entirely also we get a return of false with no exception raised, so there is no way to tell these apart.

Suggestion: return an int code, 0 for fully verified success, 1 for DANE passed but there's more to do, and -1 for no DANE found or checked at all. Something like that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant