-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make useHardcodedDnsServers static #72
Comments
Random thought: Maybe the hardcoded servers can go into their own Lookup Mechanism that can be added and removed. This would simplify the API a bit. Do that would also require that lookup mechanisms can access the ip preference as I already suggested in #12 |
I'd rather have them not as lookup mechanism, as they are a special very last resort step. I also think it makes sense for them to be not static, as it easily allows you to create different DNSClient instances using different DNS servers (Yes, that eventually would also be possible if they where a lookup mechanism, but still).
I'd rather have the part of the API processing the return DNS servers from the lookup mechanism sort the DNS server IPs by preference of the IP version. |
Correction, master already has the mechanisms and the hardcoded servers static. That means there is currently no way to create Anyway, what is really missing in master is the ability to change the hardcoded servers. @iNPUTmice shall we hijack this issue so that is says "Make hardcoded dns servers configurable"? |
Is there a reason
useHardcodedDnsServers
and the respective getter and setter methods are not static?If other settings that influence the choice of DNS server (blacklist, lookup mechanism) are it kinda makes sense to make that variable static as well.
The text was updated successfully, but these errors were encountered: