Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate rack_profiler:install in favour of rack_mini_profiler:install #550

Merged

Conversation

gmcgibbon
Copy link
Contributor

@gmcgibbon gmcgibbon commented Feb 8, 2023

The gem's name and install generator should be the same.

This deprecates the current generator in favour of a more appropriately named one. It also updates copy on the initializer comments and usage clarifying what it is doing and when to use an initializer. Behaviour is changed for the install generator to always generate a rack_mini_profiler.rb initializer instead, but I think that's acceptable if we want to rename the generator.

The gem's name and install generator should be the same.
@codecov-commenter
Copy link

Codecov Report

Merging #550 (dd4e83b) into master (edbcad3) will not change coverage.
The diff coverage is n/a.

❗ Current head dd4e83b differs from pull request most recent head 8cea50f. Consider uploading reports for the commit 8cea50f to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##           master     #550   +/-   ##
=======================================
  Coverage   87.39%   87.39%           
=======================================
  Files          18       18           
  Lines        1269     1269           
=======================================
  Hits         1109     1109           
  Misses        160      160           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@SamSaffron
Copy link
Member

I think the reason I was holding off on merging stuff was cause our test suite is not passing, looks unrelated though.

@SamSaffron SamSaffron merged commit 1d2f012 into MiniProfiler:master Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants