Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Default MPC Contract #38

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Update Default MPC Contract #38

merged 1 commit into from
Sep 13, 2024

Conversation

bh2smith
Copy link
Collaborator

@bh2smith bh2smith commented Sep 13, 2024

PR Type

enhancement


Description

  • Updated the default value of the mpcContractId option in the CLI script from v1.signer-dev.testnet to v1.signer-prod.testnet.

Changes walkthrough 📝

Relevant files
Enhancement
cli.ts
Change default MPC contract ID to production                         

examples/cli.ts

  • Updated the default value of mpcContractId option.
+1/-1     

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

@bh2smith bh2smith merged commit 687ff85 into main Sep 13, 2024
1 check passed
@bh2smith bh2smith deleted the update-default-mpc branch September 13, 2024 19:25
@mintbase-codium-pr-agent
Copy link

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ No key issues to review

@mintbase-codium-pr-agent
Copy link

PR Code Suggestions ✨

CategorySuggestion                                                                                                                                    Score
Enhancement
Add validation for the mpcContractId option to ensure it adheres to a specific format

Consider validating the mpcContractId option to ensure it matches a specific format
or pattern. This can prevent potential issues with invalid contract addresses being
used inadvertently.

examples/cli.ts [26]

 .option("mpcContractId", {
   type: "string",
   description: "Address of the mpc (signing) contract",
   default: "v1.signer-prod.testnet",
+  validate: (input) => /^v\d+\.\w+-\w+\.\w+$/.test(input)
 })
 
Suggestion importance[1-10]: 9

Why: The suggestion to add validation for the mpcContractId option is highly beneficial as it ensures that the contract ID adheres to a specific format, preventing potential issues with invalid addresses. This enhances the robustness and reliability of the code.

9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant