Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set minimum Rust Version #44

Closed
Quitlox opened this issue Dec 27, 2021 · 1 comment
Closed

Set minimum Rust Version #44

Quitlox opened this issue Dec 27, 2021 · 1 comment

Comments

@Quitlox
Copy link

Quitlox commented Dec 27, 2021

Hi there! First of all, great tool! I'm having a lot of fun with it.

While installing flavours on a different machine using cargo build (same using the AUR package), I encountered an error.

As it turns out, just upgrading my Rust version from 1.52 to 1.57 solved the issue.

It took me a second to figure out, since I am not experienced with Rust, and I imagine I am not the only one. Would it be an idea to set a minimum Rust version in cargo.toml? It seems that this is possible as of recent (rust-lang/cargo#9732).

Alternatively, I would propose to add one or two lines in the README.md stating upgrading as a potential fix for build errors. The latter I could do myself, the former is probably easier for someone with experience in Rust 😛.

@Quitlox Quitlox changed the title Configure minimum Rust Version Set minimum Rust Version Dec 27, 2021
@Misterio77
Copy link
Owner

Hey! Thank you for the report!

I'm not sure if all distros have rust 1.57 packaged, so i think i'd like to play safe and enforce 1.56, if possible. Could you check if it compiles with 1.56?

I think both solutions combined would work the best!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants