Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup of edge lengths computation in Mmg3d #275

Open
6 tasks
Algiane opened this issue May 31, 2024 · 0 comments
Open
6 tasks

Cleanup of edge lengths computation in Mmg3d #275

Algiane opened this issue May 31, 2024 · 0 comments
Labels
kind: cleanup should be clean kind: refactoring needs refactoring part: mesh adaptation mesh adaptation mode specificity part: mmg3d mmg3d specific

Comments

@Algiane
Copy link
Member

Algiane commented May 31, 2024

The edge length computation in Mmg3d contains some inconsistencies and needs to be tested and cleaned:

  • for isotropic metric, it seems that we always compute the "straight" edge length;
  • for anisotropic metric:
    • the "straight edge length is computed along internal edges
    • along boundary edges:
      • we may compute the "curve" length along edges marked by the MG_BDY tag
      • or the straight length:
        • because the tag is missing (we are not able to ensure the update of this tag everywhere)
        • because we are on a boundary edge belonging the a tetra without any boundary faces and without an xtetra (I am sure that such edges exists but not sure that we attempt to compute their lengths however)
        • because we are inside an operator when tags are not yet updated

Moreover, the readibility of this part the code needs to be improved (function names not very meaningful and complex function pointer digram)

Steps

  • function renaming to make them easier to understand
  • pointer function cleaning if possible
  • comparative tests of the effect of straigth edge length computation instead of curve one along boundary edges for anisotropic metric
  • comparative tests of the effect of straigth edge length computation instead of curve one along boundary edges for isotropic metric
  • documented choice between straight and curve edge length computation along boundary edges
  • behaviour homogenization
@Algiane Algiane added kind: cleanup should be clean kind: refactoring needs refactoring part: mmg3d mmg3d specific part: mesh adaptation mesh adaptation mode specificity labels May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: cleanup should be clean kind: refactoring needs refactoring part: mesh adaptation mesh adaptation mode specificity part: mmg3d mmg3d specific
Projects
None yet
Development

No branches or pull requests

1 participant