Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed README #21

Closed
wants to merge 5 commits into from
Closed

Fixed README #21

wants to merge 5 commits into from

Conversation

tusharpm
Copy link
Contributor

Modified the comments for the hsl function return values.

@tusharpm
Fix hue rotation and parse as float
7034be6
@tusharpm
Merge remote-tracking branch 'MoOx/master'
17596da
@tusharpm
Modification for float matching regex
d322075 
Changed the old regex to match numbers like `.5` (without digits
preceding the decimal point).
@tusharpm
Merge remote-tracking branch 'MoOx/master'
dad75b5
@tusharpm
Fix the README to show the correct expected values
3c626d2 
`getHsl` and `getHsla` rotate the hue to the standard range [0, 360).
Essentially 360 is parsed and recalculated to 0 following the logic
[here](http://www.w3.org/TR/css3-color/#hsl-color).
@Qix-
Copy link
Owner

Qix- commented Sep 30, 2015

Hey thanks for the PR :) In the future, do git pull --rebase origin master so we don't get the Merge remote-tracking branch 'MoOx/master' commits ;)

I'll merge this in the morning 👍 Thank you again!

@tusharpm
Copy link
Contributor Author

I'm still learning git. I'll do that from now on. Thanks.
On Sep 30, 2015 9:44 AM, "Josh Ballard" notifications@github.com wrote:

Hey thanks for the PR :) In the future, do git pull --rebase origin master
so we don't get the Merge remote-tracking branch 'MoOx/master' commits ;)

I'll merge this in the morning [image: 👍] Thank you again!

—
Reply to this email directly or view it on GitHub
#21 (comment).

@Qix-
Copy link
Owner

Qix- commented Sep 30, 2015

No problem :) I didn't know about git pull --rebase until a little bit ago, too.

@Qix-
Copy link
Owner

Qix- commented Jan 3, 2016

Sorry I'm just now getting to this.

In the future, try to put new things on their own branch as well ;)

@Qix-
Copy link
Owner

Qix- commented Jan 3, 2016

Thanks! Landed in 4565f55.

@Qix- Qix- closed this Jan 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tusharpm @Qix-