Skip to content
This repository has been archived by the owner on Sep 7, 2020. It is now read-only.

Consider dropping the usage of React context #304

Closed
MoOx opened this issue Mar 14, 2016 · 8 comments
Closed

Consider dropping the usage of React context #304

MoOx opened this issue Mar 14, 2016 · 8 comments

Comments

@MoOx
Copy link
Owner

MoOx commented Mar 14, 2016

react-router did it.

Props should be enough. We should at least evaluate the idea, to make things (and tests) simpler.

I want a minimal API and context make things more complicated (no big deal but still).

@thangngoc89
Copy link
Contributor

Is there reference about why react-router drop it ?

@MoOx
Copy link
Owner Author

MoOx commented Mar 14, 2016

remix-run/react-router#2646 in the middle of the desc.

@thangngoc89
Copy link
Contributor

I saw that they're moving multiple contexts into 1. Not dropping it entirely.

@MoOx
Copy link
Owner Author

MoOx commented Mar 15, 2016

Yeah but I am pretty sure we can do without those. Context is handy but not the silver bullet and make functional component not that functional :D
Will see that later.

@thangngoc89
Copy link
Contributor

Oh. I have to agree with you about this. It's hard to test component with context.

@montogeek
Copy link
Contributor

This should close #40, right?

@MoOx
Copy link
Owner Author

MoOx commented Nov 1, 2016

We should indeed, remove redux AND remove explicit context in favor of provider components.

@bloodyowl
Copy link
Contributor

Going to be fixed with #925

@MoOx MoOx closed this as completed May 11, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants