-
Notifications
You must be signed in to change notification settings - Fork 249
Config "offline": { "serviceWorker": true } seems to create appcache too #438
Comments
This is what I wrote in the docs. And this is by design, not a bug. |
Technically it's not a bug indeed, but since it's not intuitive, we need to change that. |
We can just "throw" a warning, if all 3 keys are not provided. |
It's a solution but I don't like it. :/ |
It's better than nothing right? |
Nah. I don't think so. The reason I implemented this kind of behavior in the first place because I don't want to force user to remember (or check the docs) for all the keys needed. |
Yeah but UX is bad because if you don't read the doc (or too quickly) you get an unexpected result and you will end up asking for help. |
Okie. Let's go with throwing error. #415 will resolve all the UX issues |
There is no silver bullet. Not sure a command will solve all problems like that. |
Right. But first thing first, resolve this issue first |
For now no more offline feature in v1. We will review this later. |
I tried this config and I end up with a
manifest.appcache
. If we provide only one key, should not assume other key is true.The text was updated successfully, but these errors were encountered: