Skip to content
This repository has been archived by the owner on Sep 7, 2020. It is now read-only.

Config "offline": { "serviceWorker": true } seems to create appcache too #438

Closed
MoOx opened this issue May 5, 2016 · 11 comments
Closed

Comments

@MoOx
Copy link
Owner

MoOx commented May 5, 2016

I tried this config and I end up with a manifest.appcache. If we provide only one key, should not assume other key is true.

@MoOx MoOx added the bug label May 5, 2016
@thangngoc89
Copy link
Contributor

thangngoc89 commented May 5, 2016

Contains 3 keys. Please be aware that you don't need to define all of 3 keys. They will be defined with their default values.

This is what I wrote in the docs. And this is by design, not a bug.

@MoOx MoOx added enhancement and removed bug labels May 5, 2016
@MoOx
Copy link
Owner Author

MoOx commented May 5, 2016

Technically it's not a bug indeed, but since it's not intuitive, we need to change that.

@MoOx
Copy link
Owner Author

MoOx commented May 9, 2016

We can just "throw" a warning, if all 3 keys are not provided.

@thangngoc89
Copy link
Contributor

It's a solution but I don't like it. :/

@MoOx
Copy link
Owner Author

MoOx commented May 9, 2016

It's better than nothing right?

@thangngoc89
Copy link
Contributor

Nah. I don't think so. The reason I implemented this kind of behavior in the first place because I don't want to force user to remember (or check the docs) for all the keys needed.

@MoOx
Copy link
Owner Author

MoOx commented May 9, 2016

Yeah but UX is bad because if you don't read the doc (or too quickly) you get an unexpected result and you will end up asking for help.

@thangngoc89
Copy link
Contributor

Okie. Let's go with throwing error. #415 will resolve all the UX issues

@MoOx
Copy link
Owner Author

MoOx commented May 9, 2016

There is no silver bullet. Not sure a command will solve all problems like that.

@thangngoc89
Copy link
Contributor

Right. But first thing first, resolve this issue first

@MoOx
Copy link
Owner Author

MoOx commented May 11, 2017

For now no more offline feature in v1. We will review this later.

@MoOx MoOx closed this as completed May 11, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants