fixed crash due NPE in case Locale's country has "no currency" #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -97,6 +97,11 @@ public DecimalFormatSymbols(Locale locale) { | |||
| this.locale = locale; | |||
| try { | |||
| currency = Currency.getInstance(locale); | |||
| if (currency == null) { | |||
| // dkimitsa: for some countries there is no currecy like Antarctida AQ so pick currency | |||
There was a problem hiding this comment.
currecy -> currency
directcly -> directly
There was a problem hiding this comment.
fixed as part of #315
dkimitsa
added a commit
to dkimitsa/robovm
that referenced
this pull request
Jul 3, 2018
florianf
pushed a commit
that referenced
this pull request
Jul 7, 2018
* fixed #309 Cannot Use Step Filters while Debugging in Eclipse * EXCEPTION_ONLY validation fixed (root case) * JDWP version downgraded to 1.5 as Eclipse uses features that are not supported * robovm.version set to 2.3.5-SNAPSHOT * fixed spelling as per #311 (review)
dkimitsa
added a commit
to dkimitsa/robovm
that referenced
this pull request
Jan 3, 2019
* fixed MobiVM#309 Cannot Use Step Filters while Debugging in Eclipse * EXCEPTION_ONLY validation fixed (root case) * JDWP version downgraded to 1.5 as Eclipse uses features that are not supported * robovm.version set to 2.3.5-SNAPSHOT * fixed spelling as per MobiVM#311 (review) (cherry picked from commit d152b61)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
such as Antarctica