Add support for bzlmod #1502
Merged
Add support for bzlmod #1502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI: #1503 |
|
FYI, the repo now uses Bazel 6.0. |
BalestraPatrick
force-pushed
the
pb/bzlmod
branch
from
dd7b1b0 to
8f9ccb4
Compare
|
As part of this do we want to enable bzlmod in |
|
Yeah, I think that's a good idea. We might also need to create a |
If we can do that instead of disabling bzlmod, I would prefer that. |
BalestraPatrick
added a commit
to bazelbuild/rules_swift
that referenced
this pull request
Jan 5, 2023
When building Swift code with `--enable_bzlmod`, it currently fails due to the worker failing to find the `index-import` executable in the runfiles. This is because the naming is different under bzlmod and the C++ runfiles library was updated to support this new mapping as described in this [talk](https://www.youtube.com/watch?v=5NbgUMH1OGo). Since rules_swift supports both Bazel 5 and 6, we need to check `BAZEL_CURRENT_REPOSITORY` is defined to simply make use of the new constructor which will make it so the runfiles lookup will happen relative to the `rules_swift` repo under Bazel 6. I tested this locally with a `local_path_override` while iterating on getting the `rules_xcodeproj` to work under bzlmod (and also continues to work with bzlmod disabled in Bazel 6): MobileNativeFoundation/rules_xcodeproj#1502
BalestraPatrick
force-pushed
the
pb/bzlmod
branch
3 times, most recently
from
a75dfff to
718391c
Compare
brentleyjones
force-pushed
the
pb/bzlmod
branch
from
718391c to
bba2617
Compare
BalestraPatrick
force-pushed
the
pb/bzlmod
branch
7 times, most recently
from
45b667b to
d5acf95
Compare
BalestraPatrick
force-pushed
the
pb/bzlmod
branch
2 times, most recently
from
0dc414e to
1ee9b45
Compare
BalestraPatrick
force-pushed
the
pb/bzlmod
branch
from
1ee9b45 to
7904eff
Compare
brentleyjones
pushed a commit
that referenced
this pull request
Jan 13, 2023
Split up the `rules_swift` bump from #1502.
brentleyjones
approved these changes
Jan 13, 2023
BalestraPatrick
force-pushed
the
pb/bzlmod
branch
from
7904eff to
30eea2f
Compare
tymurmustafaiev
pushed a commit
to tymurmustafaiev/rules_swift
that referenced
this pull request
Jul 19, 2023
When building Swift code with `--enable_bzlmod`, it currently fails due to the worker failing to find the `index-import` executable in the runfiles. This is because the naming is different under bzlmod and the C++ runfiles library was updated to support this new mapping as described in this [talk](https://www.youtube.com/watch?v=5NbgUMH1OGo). Since rules_swift supports both Bazel 5 and 6, we need to check `BAZEL_CURRENT_REPOSITORY` is defined to simply make use of the new constructor which will make it so the runfiles lookup will happen relative to the `rules_swift` repo under Bazel 6. I tested this locally with a `local_path_override` while iterating on getting the `rules_xcodeproj` to work under bzlmod (and also continues to work with bzlmod disabled in Bazel 6): MobileNativeFoundation/rules_xcodeproj#1502
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds initial support for bzlmod. I still have to test it with an example project, but the basic infrastructure should be ready.
bzlmod is only really ready to be used starting in Bazel 6.0. For this reason, the
MODULE.bazeldepends on rules_apple 2.0.0, which is also the release that requires Bazel 6. I will need to first check the newest version of rules_apple and rules_swift into the Bazel Central Registry, and then we can proceed testing the rules_xcodeproj integration.