Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please tag the repository! :) #200

Closed
tmontes opened this issue Dec 3, 2019 · 3 comments
Closed

Please tag the repository! :) #200

tmontes opened this issue Dec 3, 2019 · 3 comments

Comments

@tmontes
Copy link

tmontes commented Dec 3, 2019

Hello all,

Thanks for the contributions in PR #188 that has been merged about a week ago.
Could we please have the repository tagged? I'd expect, at least, a v1.0 tag that pinpoints which of the more than 20 commits claiming to be version 1.0 in their version history sections is actually version 1.0.

Again thanks.

@barbeau
Copy link
Member

barbeau commented Dec 3, 2019

I just pushed a tag for v1.0 that points to df473ca:
https://github.com/NABSA/gbfs/tree/v1.0

@jcn @antrim @heidiguenin Does this look right to you? If so, we should create a GitHub release from this tag with an explanation of what it contains. I scanned the commits and pull requests in the repo going back a bit and it seems like everything prior to PR #188 for versioning were clarifications that could still be called part of v1.0.

@barbeau
Copy link
Member

barbeau commented Dec 10, 2019

@tmontes I talked to @antrim and @heidiguenin offline and they confirmed that this tag looks good, so I went ahead and created a v1.0 release as well:
https://github.com/NABSA/gbfs/releases/tag/v1.0

@barbeau barbeau closed this as completed Dec 10, 2019
@tmontes
Copy link
Author

tmontes commented Dec 10, 2019

@barbeau, thanks. I got the tag on my side. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants