Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use OSM opening hours format? #6

Closed
fkh opened this issue Dec 19, 2015 · 6 comments
Closed

Use OSM opening hours format? #6

fkh opened this issue Dec 19, 2015 · 6 comments
Labels
gbfs.md Moved to PR proposal:breaking v3.0-RC Candidate change for GBFS 3.0 (Major release)

Comments

@fkh
Copy link
Contributor

fkh commented Dec 19, 2015

Are we trying to invent a new format for hours of operation (system_hours.json)?

What about a format that is already used and supported with code libraries—see OSM’s opening_hours (http://wiki.openstreetmap.org/wiki/Key:opening_hours)

@mdarveau
Copy link

If we are to do one last breaking change because of #10 and #9, I'd be +1 on this one. It seems more flexible while keeping things simple for producers and consumers.

@jcn
Copy link
Contributor

jcn commented Jan 19, 2016

The OSM format looks flexible, but also requires a lot more parsing than the explicit (but admittedly not as flexible) format that we defined in the spec. I'd be concerned with this significant of a change without much more discussion. Specifically, I'd be curious as to how using the OSM format would affect consumers - it seems much more brittle to me.

For reference, the current definition is here: https://github.com/NABSA/gbfs/blob/master/gbfs.md#system_hoursjson

@Empty2k12
Copy link

Good objection by @jcn. By using OSM data, we would also lose info about member and non-member opening times, unless we changed the spec to something like

Field Name Required Defines
rental_hours Yes Object containing opening hours
- rental_hours Yes OSM format rental hours for members of the system. If rental_hours_non_member is not specified, there are no differing hours for members and non-members
- rental_hours_non_member No OSM format rental hours for non-members

I can also see the clear advantage of using the same libraries for parsing the date as OSM dates which the developer of an application might already be using for parsing opening hours from OSM itself.

How could we support differing opening hours for a special event like holidays or strikes? Make that part of system alerts?
Additionally, I can think of one instance of an opening-hour restricted station in our city, which offers a comment with the opening hours, asking users to ring and they will be permitted access to the station. How can such comments be encoded with an opening hour?

@stale
Copy link

stale bot commented Nov 13, 2020

This disucssion has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 13, 2020
@josee-sabourin josee-sabourin added v3.0-RC Candidate change for GBFS 3.0 (Major release) and removed stale labels Dec 9, 2020
@mplsmitch
Copy link
Collaborator

We have a proposal to change the format for operation dates and times to OSM Opening Hours format. Since this would be a breaking change it would happen with v3.0. This is a significant revision to the specification so we'd like to get some feedback before it goes to a PR. I've written up the proposal in this document. Please comment along with your willingness to implement.

@mplsmitch mplsmitch removed this from the 2.0 milestone Jan 27, 2021
@mplsmitch
Copy link
Collaborator

Closing this - ongoing discussion of OSM Opening Hours has been moved to #289

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gbfs.md Moved to PR proposal:breaking v3.0-RC Candidate change for GBFS 3.0 (Major release)
Projects
None yet
Development

No branches or pull requests

7 participants