Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API GTFS schedule sources compatibility #130

Closed
3 tasks
emmambd opened this issue Apr 7, 2022 · 3 comments · Fixed by #188
Closed
3 tasks

Add API GTFS schedule sources compatibility #130

emmambd opened this issue Apr 7, 2022 · 3 comments · Fixed by #188
Assignees
Labels
enhancement New feature or request

Comments

@emmambd
Copy link
Contributor

emmambd commented Apr 7, 2022

What problem are we trying to solve?

Right now, GTFS schedule sources that are served by an API cannot be included in the database. We want to be able to add them.

How do we know when this is done?

  • The README is updated to include the same authentication fields for GTFS Schedule that currently exist for GTFS Realtime
  • Update GitHub workflow so keys can be stored and used for sources with an authentication type greater than 0

Tasks

@emmambd emmambd changed the title Create a conditional check on ZIP file test to accommodate API sources Create a conditional check on tests to accommodate API sources Apr 7, 2022
@e-lo
Copy link
Contributor

e-lo commented Apr 12, 2022

Right now, only sources that return a ZIP file on download can be logged in the catalogs, since we are running checks to verify if the URL opens a valid file.

Can't you store the API keys as repo secrets?

@e-lo
Copy link
Contributor

e-lo commented Apr 12, 2022

It seems like a format like {API_KEY_<MBD_ID>} could be little easier for storing keys as repo-secrets – but also could do {API_KEY} and then do the joining to MBD_ID on the backside.

@maximearmstrong
Copy link
Contributor

Can't you store the API keys as repo secrets?

Yes we can. We should store them so that the daily cron job downloads the latest dataset, unless we should not make publicly available datasets requiring an API key to be downloaded. This is most likely something described by the license, so it would be on a case by case basis.

@emmambd emmambd added the enhancement New feature or request label May 31, 2022
@emmambd emmambd changed the title Create a conditional check on tests to accommodate API sources Add API GTFS schedule sources compatibility Jul 13, 2022
@maximearmstrong maximearmstrong self-assigned this Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants