New module uploaded (keypad)

[salarizadi]

happy New Year ! I'm back with a new module to set up all kinds of matrix keypads, from now on you can easily set up your own matrix keypads

https://github.com/salarizadi/moddable-sdk/tree/main/Modules/keypad

[phoddie]

Very nice. That will be useful for other developers. It also looks like you implement debounce, which is important. You might want to mention that in the docs.

In reading the implementation, I had a couple of minor observations.

#pins = {}

#pins is declared as an object but always accessed as an Array. It works, but it would be more clear if the initial value of #ipns is an array, #pins = [].

    constructor (config, callback) {
        if (typeof config !== "object")
            return false

It is a little unusual to have a return value from a constructor. It would be more conventional to throw an exception with an error message.

        if (typeof $this.#pins[config.pin] !== "undefined")
            $this.#pins[config.pin].close()

This can be more concisely written as: $this.#pins[config.pin]?.close()

[phoddie]

One more observation. You use .map() on the row and column arrays, but always discard the result. In that case, it would be more efficient to use .forEach() to avoid creating a new array that is never used. For example, this...

        this.#config.rows.map(pin => this.#pin({
            pin : pin,
            mode: Digital.InputPullUp,
            edge: Digital.Falling
        }))

....would become....

        this.#config.rows.forEach(pin => this.#pin({
            pin,
            mode: Digital.InputPullUp,
            edge: Digital.Falling
        }))

[salarizadi]

I saved the pin settings (digital class) with the object and the #pins keys are the numbers of the pins that have been entered. See this line of code. Here I got the pin value so that I can perform the operation

[salarizadi]

You mentioned a good point. I rewrote and deleted the codes several times so that I could write this module very accurately and logically. It is normal that some code remains from the previous code that I changed. The things you reported are true, but I want to tell you. Let me explain a part of the previous code: first look at this line of code

If you look carefully, the #compressed function is called in this function. Before that, I had written this function in a different way in the onReadable function of the Digital class. That's why I defined the function like this. Instead of () => {}, I wanted to directly have this.read() to get the pin value, but I saw that I needed more operations, so I went back and changed the codes. Now you understand why some code doesn't make sense. Yes, I could have used this instead of $this. I wrote the codes without sample code, I changed several times to be able to identify the keys exactly. It sounds simple, but it's a bit complicated.

[salarizadi]

It is interesting that I had not paid attention to this until now. Using map creates a new array. This can also be changed and I change it to forEach. Thanks for the tips you reported

[salarizadi]

Now that I paid attention, I was able to write the codes much better and lighter. I will definitely update the codes as soon as possible. I really appreciate your detailed review.