Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Vite 5.0 #22

Closed
undergroundwires opened this issue Nov 16, 2023 · 6 comments
Closed

Support Vite 5.0 #22

undergroundwires opened this issue Nov 16, 2023 · 6 comments

Comments

@undergroundwires
Copy link

Hi,

First of all thank you for this super easy-to-use plugin. It has been a joy to use it without any issues and it empowers builds of privacy.sexy.

Vite 5 is released and this package requires maximum of Vite 4.x as peer-dependency.

Can we update it to support Vite 5 so it does not block users' migration?

@tonyketcham
Copy link
Collaborator

tonyketcham commented Nov 24, 2023

Absolutely! We're working on an upgrade but are blocked by some backwards compatibility issues between the Vite 4.0 and 5.0 Plugin TS type.

The Plugin type has changed substantially and means that although this plugin works in a backwards compatible way, we get a type error thrown in the vite.config.ts of projects running an older version of Vite.

We can deprecate previous versions of Vite, but it's likely for people on large projects which are on <5.0 (say, on vite@4.0.3), installing @modyfi/vite-plugin-yaml@latest would result in an unclear npm warning + build error

@undergroundwires
Copy link
Author

How about bumping the major version on @modyfi/vite-plugin-yaml and guide users to right major versions based on which version of Vite they run on README.md? I think it would be clear and user-friendly way matching developer expectations if it's not possible to break backwards compatibility.

@Gotos
Copy link

Gotos commented Jan 2, 2024

I saw that someone started publicly working on this as #24 - is there anything else that would help get vite 5 support soon?

@Gotos
Copy link

Gotos commented Jan 11, 2024

I don't mean to bother you, but did you have a chance to look closer at this, @tonyketcham? Or do you have an idea of when you might get around to it?

I understand if working on this isn't your priority right now, I'm just asking so I can plan around it myself. If you don't have the capacity to work on this right now, that's perfectly fine!

@tonyketcham
Copy link
Collaborator

Apologies for the lengthy delay, totally my fault! I'm planning on having this sorted by the end of this week with a release :)

@tonyketcham
Copy link
Collaborator

This has been shipped in v1.1.0! 🎉
https://github.com/Modyfi/vite-plugin-yaml/releases/tag/v1.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants