Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ParagraphStyleExt.kt (fixes #190) #211

Conversation

MedvedevaElena
Copy link
Contributor

Fixed unmerge() and isSpecifiedFieldsEquals() functions when value is not nullable and have a field Unspecified

This will fix an issue, when we need to select a button, that indicates is align is Left, right or center:
state.currentParagraphStyle.textAlign == TextAlign.Left
state.currentParagraphStyle.textAlign == TextAlign.Center
state.currentParagraphStyle.textAlign == TextAlign.Right

Fixed unmerge() and isSpecifiedFieldsEquals() functions when value is not nullable and have a field Unspecified
@MedvedevaElena
Copy link
Contributor Author

fixes #190

@MedvedevaElena MedvedevaElena changed the title Update ParagraphStyleExt.kt Update ParagraphStyleExt.kt (fixes #190) Mar 6, 2024
Copy link
Owner

@MohamedRejeb MohamedRejeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contribution!

@MohamedRejeb MohamedRejeb merged commit 0e85ebb into MohamedRejeb:main Mar 6, 2024
@MedvedevaElena MedvedevaElena deleted the hotfix/paragraph_style_unmerge_when_unspecified branch March 7, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants