Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export html with tags instead of styling when applicable #219

Merged
merged 4 commits into from
Mar 24, 2024

Conversation

donovan-fournier
Copy link
Contributor

This PR updates the formatting of the HTML output.

Before:

  • Bold, italic ... were decoded as CSS styling, inline in the "span" tag. This will lose the semantic of these basics tags

After:

  • When a matching tag (same as encode), we are replacing the styling by a dedicated tag.

This PR does not handle Header styles as Heading are paragraphs, not spans, and needs a special care.
⚠️ The HTML output is not the same as before, and can be considered as a breaking change
This may address this issue #188 and our own use-case.

@MohamedRejeb MohamedRejeb self-requested a review March 21, 2024 18:41
Copy link
Owner

@MohamedRejeb MohamedRejeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your contribution.

@MohamedRejeb MohamedRejeb merged commit 964839a into MohamedRejeb:main Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants