-
-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sourcemap weirdness #180
Comments
Hi, Thanks for such a Great PR, It's a joy to see rtlcss has finally made it to the official bootstrap 👍 Yes, indeed, parsing CSS strings without setting its input source produces such result. Do you think it's better to have it point to the original file instead of |
If possible, I guess it'd be better indeed. I'm wondering what you mean by "without setting its input source": is there some way to set the input on our side? |
This need to be changed inside the plugin. The source can be set in postcss parse options const root = postcss.parse(css, { from: 'a.css' })
root.source.input.from //=> "/home/ai/a.css"
const root = postcss.parse(css)
root.source.input.from //=> "<input css 1>" |
Nice, I need to check if it suits our need. As I said, that's not a bug at all. Thanks for your help! |
@MohammadYounes Thanks a lot, it's really better! We now have |
For folks who find this issue trying to debug their application, here's the fix that was released in 2.6.2: 80c15f2 |
Hi there!
I'm currently working on implementing RTL on Bootstrap v5, and while doing so I noticed that sourcemaps for RTLCSS processed files have some weirdness:
%3Cinput%20css%202%3E
(which results in<input css 2>
);/* rtl:raw */
directive.So this is not really bug IMHO, however I think this should either be "customized" to mention something like "RTLCSS raw directive" or at least be mentionned somewhere in RTLCSS docs.
I'm not sure customizing sourcemaps in that case is doable, but would be really great 👍
Thanks for your invaluable work, I'd be pleased to have some review from you one day ❤️
The text was updated successfully, but these errors were encountered: