Allow resource pattern type to be set when managing ACLs

[dmazhar-cogniance]

Hi! Thanks for the awesome provider!
One thing that I'm missing in the ACL resource is an option ot set the resource-pattern-type. This allows to define ACLs with topic prefixes for example. So instead of creating the ACL with topic name I can set the topic prefix only. This is described in Kafka documentation: https://kafka.apache.org/documentation/#security_authz_cli (see --resource-pattern-type option).

It looks like implementing this would be tricky as sarama does not support this yet, am I right?

[Mongey]

Hi! Thanks for the awesome provider!

You're welcome!

It looks like implementing this would be tricky as sarama does not support this yet, am I right?

You're correct, resource-pattern-type was added in v1 of CreateACLRequest, and sarama only supports v0.

It's a pretty small change to the protocol -- I should be able to implement it in sarama and support it in this provider. The only tricky part will be optionally supporting this based on the version of Kafka that's targeted -- as resource-pattern-type only has an effect on Kafka 2.0 and above.

[dmazhar-cogniance]

Failing if kafka 1.x is used is an option too! :) Another option will be to pass kafka version in the provider 🤔

[Mongey]

Another option will be to pass kafka version in the provider 🤔

👍 I'll probably go with this

📝 I've started on the sarama changes over @ IBM/sarama#1236. It's a bit more work than expected, as it requires updating Describe & Delete alongside Create.